[advocacy-discuss] 2 Reviews

[Shawn Walker]

Stephen Hahn wrote:
> * Shawn Walker <shawn.walker at sun.com> [2008-07-16 18:25]:
>> Stephen Hahn wrote:
>>> * Philip Torchinsky <Philip.Torchinsky at sun.com> [2008-07-16 14:34]:
>>>> 2. Update took 1 hour 20 minutes for me because pkg image-update 
>>>> downloaded 1,5 G of data. It looked odd to me - download 1,5G to update a 
>>>> system freshly installed with 640M CD.
>>>   Compression factors makes the comparisons here less than obvious.  The
>>>   ISO image is compressed, so that 600 - 700 MB is actually 2 GB
>>>   uncompressed.  pkg(1) reports the uncompressed size of the update (but
>>>   downloads compressed data, so it's only pulling 500 MB or so over the
>>>   network).
>> I think that's probably something we should change. I was a little 
>> surprised by this behaviour when I first used image-update myself. I was 
>> expecting to report the size of what it was downloading not what it was 
>> installing during the download phase.
> 
>   We'll need to store the compressed size on those actions with
>   payloads, as well as the uncompressed size.  (And we might as well
>   have a hash for the compressed payload, too.)  Care to file the bug(s)?

Done.

We actually already had an existing bug that was pretty similar (1018). 
I've modified it to suit our new direction.

I also filed bug 2556 about the client's behaviour during the download 
phase.

-- 
Shawn Walker