[brandz-discuss] brandz zone install: first impressions

[Dan Price]

On Mon 02 Oct 2006 at 08:15PM, William Kucharski wrote:
> Dan Price wrote:
> 
> >Could this be formatted to 80 columns please?
> 
> The text is all run through gettext for internationalization purposes, so
> we can't really do 80 columns easily.

Your english language messages could be.  There is no excuse for:

> The install will attempt to use the default system
> removable disc device if <archive dir> is not
> specified.
>
> <cluster> specifies which package cluster you wish
> to install. The desktop cluster will be installed
> by default.

For example, 'zoneadm help' does not suffer from this problem.
This could be:

> The install will attempt to use the default system removable disc deviceo
> if <archive dir> is not specified.
>
> <cluster> specifies which package cluster you wish to install. The desktop
> cluster will be installed by default.

Which is two lines shorter = more comprehensible.

> The usage message states that -d can either specify a tar ball file or a 
> directory that contains ISO files.  Since an ISO file is just a regular 
> file, there's no way to tell if a file is an ISO or not without attempting 
> to mount it.

Sure, but I don't see anything about a recursive search of that
directory-- and it surprises me that it would do so.  In my opinion this
was a non-obvious cause for failure.  As a benchmark, 'pkgadd' does not
do this.

	-dp

-- 
Daniel Price - Solaris Kernel Engineering - dp at eng.sun.com - blogs.sun.com/dp