[brussels-dev] mac_update_reg <-> mac_maxsdu_update

[sowmini.varadhan at sun.com]

On (09/19/07 11:51), Artem Kachitchkine wrote:
> Looks good to me. A couple of aesthetic questions:
> 
> The get function returns both min and max values, while the update 
> function is for max only. Is there never a need to change min? Is the 
> lack of symmetry due to that?

there's never a need to change the min.
However, the specific review input here was that we want to have
functions of the form mac_<foo>_update, so if there was a need to
update the min, we would have to add mac_minsdu_update. 

> Some functions in the same group are called refresh, others update. Is 
> there a subtle difference or just sloppy naming?

The update functions update specific (mutable) fields in the mac_impl_t
with the new scalar value provided. (If you are on SWAN, the cv gate
can be cscoped at /net/zhadum.east/export/ws/clearview/clearview/usr/src
to view more examples of the *_update functions)

The refresh functions, on the other hand,  are more complex: they invoke
the callback refresh function provided to do a wider range of operations.
For example, mac_multicst_refresh could add/remove a port to the
aggregation, so that new multicast addrs could get added for the group
(as opposed to updating some existing field).

--Sowmini