[brussels-dev] mac_update_reg <-> mac_maxsdu_update
Artem Kachitchkine
Artem.Kachitchkin at Sun.COM
Wed Sep 19 12:31:06 PDT 2007
> there's never a need to change the min.
> However, the specific review input here was that we want to have
> functions of the form mac_<foo>_update, so if there was a need to
> update the min, we would have to add mac_minsdu_update.
Right. I guess the intuitive feeling is that a set of get/set/update
functions would apply to the same <foo>, so if there's
mac_maxsdu_update, there's also mac_maxsdu_get. But maybe I'm too stuck
on symmetry and should consider golden section :)
> The refresh functions, on the other hand, are more complex: they invoke
> the callback refresh function provided to do a wider range of operations.
> For example, mac_multicst_refresh could add/remove a port to the
> aggregation, so that new multicast addrs could get added for the group
(reaches for advil) Okay, okay, I agree!
-Artem
More information about the brussels-dev
mailing list