[brussels-dev] code review: mac prop handle

sowmini.varadhan at sun.com sowmini.varadhan at sun.com
Thu Sep 20 13:33:21 PDT 2007


On (09/20/07 13:30), Artem Kachitchkine wrote:
> 
>
>> Yes, rw_enter in mac_prop_update should be moved above mac_proplist_find. 
>> I'll fix that.
>
> I'm wrong, that's a different rw object. Perhaps we just need to hold on to 
> i_mac_prop_lock while using a proplist pointer. Let me think about it.
>

yeah, it's tricky because, as Thirumalai pointed out in
the discussion about freeing the mac_impl_t itself (see
http://www.opensolaris.org/jive/thread.jspa?threadID=38489&tstart=15), 
the mac layer only has control via mac_stop, but the ddi framework
controls when the detach happens. 

--Sowmini




More information about the brussels-dev mailing list