[brussels-dev] code review: several bug fixes

sowmini.varadhan at sun.com sowmini.varadhan at sun.com
Fri Sep 28 04:15:40 PDT 2007


On (09/27/07 17:46), Artem Kachitchkine wrote:
>
> The first thing any ioctl handler does is validate arguments and 
> immediately return EINVAL if something's wrong. That could include cases 
> with strings that are not nul-terminated. The advantage is that the rest of 
> the code doesn't have to worry about it.

true, but the general convention in networking seems to be 
adopt strn* functions. maybe to protect against very long strings? 
not sure.

--Sowmini





More information about the brussels-dev mailing list