[brussels-dev] Brussels- nddcompat code review

[Sebastien Roy]

Sowmini.Varadhan at Sun.COM wrote:
> On (03/29/08 08:23), Sebastien Roy wrote:
>> I like the approach, and FWIW, I don't really care either way about the  
>> isatty() thing.  Are you going to incorporate this into your main  
>> webrev, or would you like a review of this webrev?  For example, I see  
>> that there's still a printf() debug statement in there, so I'm not sure  
>> if you're ready for it to be reviewed.
> 
> Webrev has been updated to fix the printf. I think the isatty()
> check is probably safer to have, just as a sanity check.  Could you
> review, please?

usr/src/cmd/cmd-inet/usr.sbin/ndd.c

* 74: You don't need "cp"; you can pass buf as an argument to 
dladm_get_linkprop, can you not?

* 75: Just verifying: Is it a fact that all links that support 
NDD-compatibility properties support the "flowctrl" property?

* 109,304: This warning seems a bit too generic sounding.  Not all ndd 
commands are obsolete.

* 109,304: Not lint clean (need (void) cast for the fprintf() call).

* 303,108: These are duplicate blocks of code.  I'd rename isgldv3() to 
print_gldv3_warning() or some such thing and plop the fprintf() in there.

-Seb