[brussels-dev] [clearview-discuss] softmac and Brussels public properties
Peter Memishian
peter.memishian at Sun.COM
Mon Jan 28 09:27:27 PST 2008
> Playing around with today's Nevada nightly on a system with a Cassini
> card, I can't help but be annoyed at the following bit of output from
> show-linkprop:
>
> bash-3.2# dladm show-linkprop
> LINK PROPERTY VALUE DEFAULT POSSIBLE
> ce0 autopush -- -- --
> ce0 zone -- -- --
> ce0 link_duplex full full half,full
> ce0 ifspeed 1000 1000 10,100,1000
> ce0 link_up up up up,down
> ce0 adv_autoneg_cap ? 1 1,0
> ce0 default_mtu ? -- 68-9000
> ...
>
> The "?" for the "default_mtu" property is just unnecessarily lame, since
> the entire Nemo framework, including the softmac module acting on the
> behalf of the ce driver, know what the MTU of ce0 is. Would it make
> sense to have the softmac driver implement a mc_getprop() that returns a
> valid MTU? It seems like a no-brainer to me.
As does dropping the redundant and ugly "default_" part of the name.
Speaking of redundant, I also can't fathom why we have "link_duplex"
instead of just "duplex", and a link_up property that takes "up" and
"down" as values instead of "yes" and "no".
Would the Brussels team support a fasttrack cleaning up these names a bit?
--
meem
More information about the brussels-dev
mailing list