[brussels-dev] webrev request: afe and mxfe conversions to Brussels

sowmini.varadhan at sun.com sowmini.varadhan at sun.com
Wed May 14 07:33:58 PDT 2008


On (05/13/08 16:30), Garrett D'Amore wrote:
> 
> Webrev is at http://cr.opensolaris.org/~gdamore/afe-mxfe-brussels/
> 

Changes look good, but do these drivers not support mtu? What
about flowctrl? 

The only other minor nit is that instead of using so many uint8_t's,
for the MII props (most of which are 0/1), you could have used
bits in a uint32_t. But that's a nit that I'll let you use
your judgement on.

--Sowmini



More information about the brussels-dev mailing list