[caiman-discuss] hsfs readahead changes, review comments/feedback

[Moinak Ghosh]

Hi Frank,

   Updated webrevs are put up at:

http://www.genunix.org/distributions/belenix_site//binfiles/hsfswebrev/index.htm

I have incorporated all the comments, fixes, cstyle and lint
cleanup etc.

One point though:

> - Likewise, there are five "if (fsp->hqueue) {}" blocks in getapage;
>    that pretty much splatters the readahead code all over and I'd
>    think it'd be much easier to understand/troubleshoot if one would
>    block the code into one "if (fsp->hqueue} { ...; return (0);}"
>    section and the normal code for 'whatever else'.

I have reduced five if (fsp->hqueue) {} blocks down to four.
However the remaining checks are for different stuff at
widely distinct points, like inside and outside loops. I am not
sure how I can reduce these checks without duplicating
most of the function code in a big if ... else block.

I am currently running the tests and will let you know once
it is done.

Regards,
Moinak.

Moinak Ghosh wrote:
> [...]
>
>>
>> Best regards,
>> FrankH.
>>
>>>
>>> Regards,
>>> Moinak.
>>>
>>>> Thanks,
>>>> FrankH.
>>>>
>>>>
>>>>> Regards,
>>>>> Moinak.
>>>>>
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>
>>>
>>>
>>
>> ------------------------------------------------------------------------------ 
>>
>> No good can come from selling your freedom, not for all the gold in 
>> the world,
>> for the value of this heavenly gift far exceeds that of any fortune 
>> on earth.
>> ------------------------------------------------------------------------------ 
>>
>
>