[caiman-discuss] Code review request for bug 945 libbe: be_list needs better active on reboot checking

[Ethan Quach]

Evan Layton wrote:
> Ethan Quach wrote:
>   
>> Evan,
>>
>> be_utils.c
>>
>> 588 - Doesn't seem like you need to check found_default here.  You
>> wouldn't be here unless it was True because of the check on 577.
>>
>> 590,594 - Does this assume that the bootfs line is always the next
>> line under title?  If so, needs to be fixed.
>>
>>     
>
> There was a problem in this area however that could have caused a problem. I've 
> address this as well and updated the webrev.
>   

Looks okay now.

-ethan


> -evan
>
>   
>> -ethan
>>
>>
>> Evan Layton wrote:
>>     
>>> I need a review of
>>>
>>> http://cr.opensolaris.org/~evanl/snap_945/
>>>
>>> which addresses
>>>
>>> 945 libbe: be_list needs better active on reboot checking
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=945
>>>
>>> Thanks!
>>> -evan
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>       
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>