[caiman-discuss] Code review for bug 434

[Moinak Ghosh]

Shawn Walker wrote:
> On Jan 29, 2008 9:35 PM, Anil Gulecha <anil.verve at gmail.com> wrote:
>   
>> Hi,
>>
>> I've modified the live-fs-root file in the slim_prototype repo to be
>> able to boot usb without checking for /.liveusb. This will allow the
>> same minirot to be used for both cd and usb.
>>
>> The bug is filed at http://defect.opensolaris.org/bz/show_bug.cgi?id=434
>> and code review at http://cr.opensolaris.org/~anilg/001_fsroot/
>>     
>
> So, why leave these lines:
>
>        42 +#[ -f /.liveusb ] && LIVEUSB=1
>
>       193 +                        LIVEUSB=1
>       194 +                        export LIVEUSB
>
>
> I know this sounds odd, but would noatime be appropriate here as well?
>
>       191 +                        /usr/lib/fs/ufs/mount -o nologging
> $dev /.cdrom 2> /dev/msglog
>   

   Yes, noatime will be appropriate.

Regards,
Moinak.