[caiman-discuss] Code review for bug 434

[Anil Gulecha]

On 2/1/08, Alok Aggarwal <Alok.Aggarwal at sun.com> wrote:
>
> On Thu, 31 Jan 2008, Anil Gulecha wrote:
>
> > New review at http://cr.opensolaris.org/~anilg/001_fsroot_v5/
> >
> > Summary of changes:
> >
> > *Modify script to first check for a USB device, and if not found, CD.
> > *Copyright updated
> > *Signature check in ufs filesystem
> > *Changed hardcode of /dev/lofi/2 to a variable
> > *Changed mounted check from filesystem to a variable.
> > *Added error checking for /usr/ and /mnt/misc mount commands
>
> line 183: I would slightly reword the comment and say something
> along the lines of, "Determine if any of the USB devices contain
> a UFS filesystem. For devices that do, attempt to mount them to
> see if the compressed /usr filesystem exists".
>
> line 193: It doesn't look like the LISTUSB variable is used
> anywhere in this script.
>

This can be used by any further scripts to determine if we are in a
LiveUSB environment and do some action.

> line 197: The stderr and stdout output gets displayed. Is this
> something you really want or would you rather discard/redirect
> it to /dev/msglog?

Will add "2 > /dev/msglog"

>
> line 235: /dev/lofi/1 is hard coded here whereas it would be
> cleaner to do the same thing you do on line 245.

I couldnt figure out a way to do this in sh as the lofiadm command is
begin run in the background.. What is the method to capture o/p from a
background process in sh?

>
> line 245: Nit - LOFI_MISC_DEV might be more descriptive.

will change.

Anil