[caiman-discuss] [Fwd: Re: Request for your input on bug1173]

[Sanjay Nadkarni]

om_proc.c:


Hi Joe,
    Here are few more comments.

om_proc.c

    check_each_proc:
    232:  why are is 10 being subracted from sizeof(pname) ?  A comment 
explaining that would help.

    255,262: It would be useful to include errno in the debug output.







Joseph J VLcek wrote:
> Niall Power wrote:
>   
>> Hi Joe,
>>
>> Quoting part of the original 
>> e-mail exchange for reference:
>>
>> "I agree that the second client should exit
>>
>> and post an error message. If the client is a GUI client, then it
>>
>> should post a visible error dialog. Note that while not preferred, it
>>
>> is OK if the GUI actually displays the Welcome prior to displaying the
>>
>> error dialog - the display of the Welcome screen should not be
>>
>> significantly delayed (>1 second) by this check."
>>
>> To clarify, the optimal solution is to not show the welcome screen and
>> instead show the error dialog as soon as possible. There is no benefit
>> in showing the welcome screen when it will not be accessible. This 
>> also avoids kicking off unwanted activities such as target discovery.
>>     
>
>
> Thanks you Niall.
>
> This is what I have  implemented. I have posted an updated webrev.
>
> Again thank you for  your help and  input.
>
> Joe
>
>
>   
>> Thanks,
>> Niall
>> --
>> This message posted from opensolaris.org
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>     
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>