[caiman-discuss] Distro-constructor finalizer with messages through sockets

[Dave Miner]

Jack Schwartz wrote:
> Thanks for your review, Dave.
> 
> Dave Miner wrote:
>> Jack Schwartz wrote:
>>   
>>> Hi everyone.
>>>
>>> Here is a code review of the Distro-Constructor finalizer module vs the 
>>> one previously reviewed.  It now supports sending stdout or stderr 
>>> through sockets so a tool can pick up the messages and show them 
>>> properly.  Please let me know your comments by Thursday.
>>>
>>> http://cr.opensolaris.org/~schwartz/080225.1/
>>>
>>>     
>> These were pre-existing points since I hadn't gotten 'round to the 
>> original review:
>>
>> 422,428: why not just do the appened of "(" at 411?
>>   
> Thanks.  Done.
>> 542: Let's not get in the habit of leaving commented-out code around
>>   
> OK.  Removed.
> 
> Updated webrev posted (slightly different location as I get used to 
> cr.opensolaris.org):
>     http://cr.opensolaris.org/~schwartz/080225.1/webrev/index.html
> Note: there is also a small new file which I forgot to post earlier, so 
> I'll leave the review open for an extra few days (until next Tuesday 
> lunchtime)
> 

With respect to the new file, why is isNumberType() not sufficient for 
what you're doing?

Dave