[caiman-discuss] Code review request for: 1299 orchestrator shouldn't take care of creating <root_pool>/ROOT dataset

[jan damborsky]

Hi Ethan,


Ethan Quach wrote:
>
>
> jan damborsky wrote:
>> Hi Ethan,
>>
>> I have done the changes in accordance with your
>> comments.
>>
>> I have also removed redundant code responsible for
>> creating "/a" mountpoint in ti_zfm.c - zfs_mount()
>> called by be_mount() takes care of it.
>>
>> Could you please take a look at updated webrev ?
>
> The changes for this fix look okay to me.
>
>
> (One note I have, as a separate issue, is that the
> mountpoint used to mount the created target BE is
> embedded in libti.  This should perhaps be a parameter
> passed in by the caller of libti)

You are right - I have filed following CR to address this problem:

1906 BE mountpoint shouldn't be hardcoded in libti
http://defect.opensolaris.org/bz/show_bug.cgi?id=1906


Thanks a lot for code review !
Jan

>
> thanks,
> -ethan
>
>
>>
>> http://cr.opensolaris.org/~dambi/bug-1299-1/
>>
>> Thank you,
>> Jan
>>
>>
>>
>> Jan Damborsky wrote:
>>> Hi Ethan,
>>>
>>>
>>> Ethan Quach wrote:
>>>> Jan,
>>>>
>>>> This is just cruft cleanup, but libti/ti_zfm.c - line 53 can
>>>> be removed as well.
>>> Thanks for catching this - I will remove it.
>>>
>>>> Do we need to adjust the "cb_data.percentage_done" in the various
>>>> places in do_ti() at all now, or does it really not make a
>>>> difference?
>>> I am not sure - I will take a closer look at particular TI phases
>>> and will recalibrate if necessary.
>>>
>>>> Everything else looks okay.
>>> Thanks for reviewing this !
>>>
>>> Jan
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss