[caiman-discuss] Code Review for 1868

[Tim Knitter]

Dave Miner wrote:
> Tim S. Knitter wrote:
>> Can someone please review the following?
>>
>> 1868 beadm destroy creates an empty grub menu
>>
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1868
>> http://cr.opensolaris.org/~tsk/1868_slim/
>>
> 
> The fix seems a little problematic yet.  The sequencing you've chosen 
> here means that if we fail to activate the current menu item (which, 
> though fairly unlikely, is certainly possible), then we still end up 
> with a GRUB menu without an active entry.  I'd rather we did things in 
> an order that made that not possible.
> 

Right. So activate first then destroy. If the destroy fails at least there will be an 'active on boot' item. I'll make that change and test it out.

Thanks
Tim

> Dave