[caiman-discuss] New XML DOM tree traversal module

Dave Miner Dave.Miner at Sun.COM
Thu May 8 15:15:53 PDT 2008


Jack Schwartz wrote:
...
> 
> Please review at http://cr.opensolaris.org/~schwartz/080404.1/review
> 
> TreeAcc.py is the module.  A few test programs and a test XML file are 
> also there for demo/experimentation.
> 

Not much that I could find, just a few nits

TreeAcc.py

269-271: stylistically it may be better to split these across two lines

333: is there a reason why this and the other static methods don't have 
the @staticmethod decorator?

393: "methods"

531,631: commented-out code left

789: continuation indent

Dave


More information about the caiman-discuss mailing list