[clearview-discuss] [networking-discuss] Code review request for DLPI applications to libdlpi

[sagun shakya]

Thank you for review Seb.

I've address both the nits you have below.

Sagun


Sebastien Roy wrote:
> On Fri, 2008-04-25 at 09:49 -0400, sagun shakya wrote:
>   
>>> Here are the links to the webrev:
>>>
>>> External webrev is located at:
>>> http://cr.opensolaris.org/~sagun/libdlpi_port2/
>>>       
>
> This looks very good.  I only have two minor nits:
>
> usr/src/cmd/cmd-inet/usr.bin/pppd/sys-solaris.c
>
> * 838-845: This could be simplified slightly as:
>
> 	retv = dlpi_get_physaddr(dh, DL_CURR_PHYS_ADDR,
>             physaddr, &physaddrlen);
> 	dlpi_close(dh);
> 	if (retv != DLPI_SUCCESS) {
> 		error("Could not get physical address on %s: %s", linkname,
> 		    dlpi_strerror(retv));
> 		return (-1);
> 	}
>
> usr/src/cmd/cmd-inet/usr.sbin/sppptun/sppptun.c
>
> * 103-105: cstyle; need brackets.
>
> -Seb
>
>