[companion-discuss] Code Review Request: SFWter Added back into Companion

[Dennis Clarke]

> In previous threads in the discussion group, the status of the SFWter
> package was discussed.  While there is some chance that this will be added
> to the WOS eventually, it will not be done immediately.  Since SFWscrn and
> SFWscrnbrltty have a dependency on the package, it needs to be added back
> onto the Companion.  This is a code review request to do that.  The webrev
> is at
>
> http://companion.sunfreeware.com/downloads/sfwterwebrev/
>
> The unique aspect of the SFWter package is that it installs files in
> /usr/share/lib/terminfo/s/
> and not in /opt/sfw/.
>
> This request replaces the previous request to modify the SFWscrn and
> SFWscrnbrltty depend
> files.
>

based on this :


 37 i pkginfo
 38 i copyright
 39 i depend
 40 # source locations relative to the prototype file
 41 #
 42 # SFWter
 43 #
 44 d none usr 755 root sys
 45 d none usr/share 755 root sys
 46 d none usr/share/lib 755 root sys
 47 d none usr/share/lib/terminfo 755 root bin
 48 d none usr/share/lib/terminfo/s 755 root bin
 49 f none usr/share/lib/terminfo/s/screen 644 root bin
 50 f none usr/share/lib/terminfo/s/screen-s 644 root bin
 51 f none usr/share/lib/terminfo/s/screen-bce 644 root bin

it looks like you are dropping files into the operating system area of
/usr and that really should be a no go.

Everything related to SFWanything should stay in /opt/sfw or /usr/sfw
but not straight into /usr .

Dennis