[companion-discuss] Re: Code Review Request: Update SFWruby to version 1.8.5-p2

[Steve Christensen]

Shinsuke,

I have done a SPARC build of your code and so far have found only two minor problems.
I am going to do some full nightly builds on SPARC and x86 and will get back to
you.  Also, you might want to do your work with the most recent svn repository,
though I don't think it will make any difference to what you have done.

The first issue is in SFWrubyS/pkginfo.tmpl.  You did not change the ruby version
to 1.8.5-p2 as you did in SFWruby/pkginfo.tmpl.  There is also a new requirement
that states you need to have a file called METADATA in usr/src/cmd/ruby of the
form

Name: ruby
URL: http://www.ruby-lang.org/en/
Package Names: SFWruby, SFWrubyS
Version: 1.8.5-p2
License: GPL2
Owner:  Shinsuke Sugaya
Comments:

Thanks for the work.

Steve C.




> Hi,
> 
> I would like to propose to update SFWruby package.
> Currently,
> SFWruby includes Ruby 1.6.4. I would like to replace
> it with
> 1.8.5-p2. Since I created the patch, could you review
> it?
> 
> Ruby 1.8.5-p2:
> 
> tp://ftp.ruby-lang.org/pub/ruby/1.8/ruby-1.8.5-p2.tar.
> gz
> 
> md5sum: a3517a224716f79b14196adda3e88057
> 
> Diff:
>     http://blogs.sun.com/ss/resource/ccd_ruby.diff
> I wanted to put a webrev result.. I requested an
> account
> on cr.grommit.com 3 days ago, but I could not get
>  it yet..
>   So, I can send it directly if needed.)
>  checked this fix on nevada snv_52 for SPARC and x86.
> 
> Regards,
>   shinsuke
> 
> 
> 
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-disc
> uss
>
--
This messages posted from opensolaris.org