[companion-discuss] Re: Code Review Request: Update SFWruby to version 1.8.5-p2

[Shinsuke Sugaya]

Thank you for reviewing it!
I updated it and put webrev to:

http://cr.grommit.com/~shinsuke/cleanup/

The changes are:

 - changed version in pkgdefs/SFWrubyS/pkginfo.tmpl
   and pkgdefs/SFWruby/pkginfo.tmpl to 1.8.5.2
 - added METADATA

Regards,
 shinsuke


Laszlo (Laca) Peter wrote:
> Hi,
> 
>> Index: src/pkgdefs/SFWruby/pkginfo.tmpl
>> ===================================================================
>> --- src/pkgdefs/SFWruby/pkginfo.tmpl	(revision 89)
>> +++ src/pkgdefs/SFWruby/pkginfo.tmpl	(working copy)
>> @@ -33,9 +33,9 @@
>>  PKG="SFWruby"
>>  NAME="ruby - Object oriented interpreted scripting language "
>>  ARCH="ISA"
>> -VERSION="1.6.4,REV=0.0.0"
>> +VERSION="1.8.5-p2,REV=0.0.0"
>>  SUNW_PRODNAME="ruby"
>> -SUNW_PRODVERS="RELEASE/1.6.4"
>> +SUNW_PRODVERS="RELEASE/1.8.5-p2"
>>  SUNW_PKGTYPE=""
>>  MAXINST="1000"
>>  CATEGORY="system"
> 
> Solaris compliant VERSION strings should include integers and dots only
> (apart from the ",REV=" part of course).  So this should be something like
> VERSION=1.8.5.2
> 
> Laca
> 
> 
> On Sun, 2006-12-17 at 02:40 -0800, Steve Christensen wrote:
>> Shinsuke,
>>
>> I have done a SPARC build of your code and so far have found only two minor problems.
>> I am going to do some full nightly builds on SPARC and x86 and will get back to
>> you.  Also, you might want to do your work with the most recent svn repository,
>> though I don't think it will make any difference to what you have done.
>>
>> The first issue is in SFWrubyS/pkginfo.tmpl.  You did not change the ruby version
>> to 1.8.5-p2 as you did in SFWruby/pkginfo.tmpl.  There is also a new requirement
>> that states you need to have a file called METADATA in usr/src/cmd/ruby of the
>> form
>>
>> Name: ruby
>> URL: http://www.ruby-lang.org/en/
>> Package Names: SFWruby, SFWrubyS
>> Version: 1.8.5-p2
>> License: GPL2
>> Owner:  Shinsuke Sugaya
>> Comments:
>>
>> Thanks for the work.
>>
>> Steve C.
>>
>>
>>
>>
>>> Hi,
>>>
>>> I would like to propose to update SFWruby package.
>>> Currently,
>>> SFWruby includes Ruby 1.6.4. I would like to replace
>>> it with
>>> 1.8.5-p2. Since I created the patch, could you review
>>> it?
>>>
>>> Ruby 1.8.5-p2:
>>>
>>> tp://ftp.ruby-lang.org/pub/ruby/1.8/ruby-1.8.5-p2.tar.
>>> gz
>>>
>>> md5sum: a3517a224716f79b14196adda3e88057
>>>
>>> Diff:
>>>     http://blogs.sun.com/ss/resource/ccd_ruby.diff
>>> I wanted to put a webrev result.. I requested an
>>> account
>>> on cr.grommit.com 3 days ago, but I could not get
>>>  it yet..
>>>   So, I can send it directly if needed.)
>>>  checked this fix on nevada snv_52 for SPARC and x86.
>>>
>>> Regards,
>>>   shinsuke
>>>
>>>
>>>
>>> _______________________________________________
>>> companion-discuss mailing list
>>> companion-discuss at opensolaris.org
>>> http://opensolaris.org/mailman/listinfo/companion-disc
>>> uss
>>>
>> --
>> This messages posted from opensolaris.org
>> _______________________________________________
>> companion-discuss mailing list
>> companion-discuss at opensolaris.org
>> http://opensolaris.org/mailman/listinfo/companion-discuss
> 
>