[companion-discuss] Re: Code Review Request: Update SFWruby to version 1.8.5-p2

[Paul Cunningham]

Shinsuke Sugaya wrote:
> Thank you for reviewing it!
> I updated it and put webrev to:
> 
> http://cr.grommit.com/~shinsuke/cleanup/
> 

this looks okay to me, just a few very minor comments ...

Paul

===== Start comments ===================================

1. The copyright year should probably be changed in the changed
    files

2. Some of the changed files do not have the CDDL HEADER block
   (prototype_i386.tmpl, etc)

3. cmd/ruby/Makefile.sfw
   Do you really need the "--mandir=/opt/sfw/man" on the configure
   line

4. Shouldn't pkgdefs/SFWruby/prototype_sparc have changed (its
   not in your webrev)

===== End comments =====================================