[companion-discuss] Re: Code Review Request: Update SFWruby to version 1.8.5-p2

[Shinsuke Sugaya]

Hi all,

Can I send an integration request?

Regards,
  shinsuke


Paul Cunningham wrote:
> 
> 
> Shinsuke Sugaya wrote:
>>  > I think the Sun standard format for this is ....
>>  >
>>  > Copyright 2006 Sun Microsystems, Inc.  All rights reserved.
>>  > Use is subject to license terms.
>>  >
>>  > ie. just the current year.
>>
>> Thank you! I double checked it, and it's just a year.
>> Updated it and put it again:
>>  http://cr.grommit.com/~shinsuke/cleanup/
> 
> okay
> 
> paul
> 
>>
>>
>> Paul Cunningham wrote:
>>
>>>>>> Thank you for reviewing it!
>>>
>>>
>>> Shinsuke Sugaya wrote:
>>>
>>>> Paul Cunningham wrote:
>>>>
>>>>> Shinsuke Sugaya wrote:
>>>
>>>
>>>>>> I updated it and put webrev to:
>>>>>>
>>>>>> http://cr.grommit.com/~shinsuke/cleanup/
>>>>>>
>>>>> this looks okay to me, just a few very minor comments ...
>>>>
>>>>
>>>> Thank you for the comment.
>>>>
>>>> Updated:
>>>>  http://cr.grommit.com/~shinsuke/cleanup/
>>>
>>>
>>>>> ===== Start comments ===================================
>>>>>
>>>>> 1. The copyright year should probably be changed in the changed
>>>>>    files
>>>>
>>>>
>>>> Fixed.
>>>
>>>
>>> I think the Sun standard format for this is ....
>>>
>>> Copyright 2006 Sun Microsystems, Inc.  All rights reserved.
>>> Use is subject to license terms.
>>>
>>> ie. just the current year.
>>>
>>>>
>>>>> 2. Some of the changed files do not have the CDDL HEADER block
>>>>>   (prototype_i386.tmpl, etc)
>>>>
>>>>
>>>> Fixed.
>>>>
>>>>
>>>>> 3. cmd/ruby/Makefile.sfw
>>>>>   Do you really need the "--mandir=/opt/sfw/man" on the configure
>>>>>   line
>>>>
>>>>
>>>> Yes. The default directory was /opt/sfw/share/man.
>>>
>>>
>>> okay
>>>
>>>>
>>>>> 4. Shouldn't pkgdefs/SFWruby/prototype_sparc have changed (its
>>>>>   not in your webrev)
>>>>
>>>>
>>>> Added.
>>>>
>>>
>>>>> ===== End comments =====================================
>>>
>>>
>>> everything else looks okay to me
>>>
>>> Paul
>>> _______________________________________________
>>> companion-discuss mailing list
>>> companion-discuss at opensolaris.org
>>> http://opensolaris.org/mailman/listinfo/companion-discuss
>>>
>>
>>
>