[companion-discuss] Code Review Request: Updates of slang and slrn packages

[Paul Cunningham]

Comments ...

1. src/cmd/slrn/Makefile.sfw
    No EXFILES stuff

2. src/cmd/slrn/fix-slrn-makefile
    copyright lines need changing

3. src/pkgdefs/SFWslrn/pkginfo.tmpl
    The 'SUNW_PRODVERS=' line has 1 missing of the end.
    Seem to remember that its not allowed to have alpha chars
    in the version numbers in pkginfo lines (may be wrong - I
    forget the reason why though)

4. src/pkgdefs/SFWslrnS/pkginfo.tmpl
    alpaha chars in version

otherwise it looks okay

paul

Steve Christensen wrote:
> This is a code review request for the update of the slang and slrn packages.  Slang is update to version 2.0.7 and slrn to version 0.9.8.1pl1.  These are done at the same time since Slrn depends on Slang and only this most recent version of Slrn will work with Slang 2. 
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/slangwebrev/
> 
> Changes are mostly standard updates of version numbers, file names and locations, copyrights, and the addition of METADATA files.
> 
> Nightly builds on Nevada 56 were successful.
> 
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
>