[companion-discuss] Code Review Request: Update of GNU sed package

[Paul Cunningham]

Steve,

The only other comment I have, is being very picky :-)  ....

in files cmd/sed/install-sfw, src/pkgdefs/SFWsed/pkginfo.tmpl & 
src/pkgdefs/SFWsedS/pkginfo.tmpl the copyright lines don't need the 
"(c)" bit.

> 
> Initial comment ...
> 
> why have you removed the 'g' prefix from the installed file name,
>    ie. /opt/sfw/bin/gsed has become /opt/sfw/bin/sed ?
> As a minimum shouldn't it have a link so the old binary name is still 
> there ?  gsed -> sed

Paul


> Steve Christensen wrote:
> 
>> This is a request for a code review for the update of the GNU sed 
>> package from version 3.02 to latest version 4.1.5.
>>
>> The webrev is at
>>
>> http://companion.sunfreeware.com/downloads/sedwebrev/
>>
>> The upgrade was straightforward and builds cleanly with no protocmp 
>> errors in a nightly build in Nevada 56 on SPARC and x86.  A version of 
>> the GNU sed program (named sed, not gsed) does need to be in 
>> /opt/sfw/bin before a build is done or configure will produce errors.
>>
>> Steve Christensen
>> -- 
>> This messages posted from opensolaris.org
>> _______________________________________________
>> companion-discuss mailing list
>> companion-discuss at opensolaris.org
>> http://opensolaris.org/mailman/listinfo/companion-discuss
>>
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
>