[companion-discuss] Code Review Request: Update of SFWlpcap (libpcap) and SFWtdmp (tcpdump)

[Steve Christensen]

This is a code review request for the update of SFWlcap (libpcap) to version 0.9.6 and
SFWtdmp (tcpdump) to version 3.9.6.  Since these two items are closely connected, they are
submitted as one review.

The webrev is at

http://companion.sunfreeware.com/downloads/libpcaptcpdumpwebrev/

The details are:

1.  Update of source code files and change to .bz2 compression from .gz.
2.  Update of version numbers in Makefile.sfw, install-sfw, and pkginfo.tmpl files.
3.  Update of METADATA files.
4.  Update of Copyrights and removal of sccs ids.
5.  Patches -

     libpcap's source code has two files where the version numbers are not updated.
     This is a known bug that has already been submitted to the libpcap/tcpdump mailing
     lists.  This patch fixes this issue.

     The tcpdump patch also updates one version number and modifies the ether.h file
     so that if ETHERMTU exists in the system (which it does in Solaris in the
     /usr/include/sys/ethernet.h), the definitions in the ether.h file are ignored. This is
     the now standard fix for this problem.

A nightly build for NV62 is clean and a working tcpdump executable is created.

Steve Christensen
--
This messages posted from opensolaris.org