[companion-discuss] Code Review Request: Update of SFWnmh package

[Paul Cunningham]

Steve Christensen wrote:
> Good idea Paul.  I have done this and checked the build and it works.
> 
> The webrev has been updated.

All looks okay to me

paul

> 
> Paul Cunningham wrote:
> 
>> Steve,
>>
>> Steve Christensen wrote:
>>
>>>
>>> The webrev has been updated with the patch file info.
>>
>>
>> Minor comment on 'src/cmd/nmh/patch' file ....
>>
>> all the patch changes seem to change, in 'if' statements "==" to "=", 
>> ie. bash v unix sh v linux sh, so wouldn't it have been quicker/better 
>> just to have changed the first line of 'configure' script  ...
>>     #! /bin/sh
>> to
>>     #! /bin/bash
>> instead ?
>>
>> Paul
>>
>>>
>>> Paul Cunningham wrote:
>>>
>>>>
>>>>
>>>> Steve Christensen wrote:
>>>>
>>>>> This is a code review request for the update of the SFWnmh package 
>>>>> to version 1.2.
>>>>>
>>>>> The webrev is at
>>>>>
>>>>> http://companion.sunfreeware.com/downloads/nmhwebrev/
>>>>
>>>>
>>>>
>>>> Looks okay to me.
>>>> Your 'patch' file (see Makefile.sfw) didn't get into the webrev so I 
>>>> guess in its current state it wouldn't get committed either.
>>>>
>>>> Paul
>>>>
>>>>>
>>>>> This builds cleanly on NV 62.
>>>>>
>>>>> The changes are:
>>>>>
>>>>> 1. Update of version numbers and source code file.
>>>>> 2. Update of copyrights and removal of sccs ids.
>>>>> 3. Addition of METADATA file.
>>>>> 4. The addition of a patch to configure that fixes a known bug in this
>>>>>     version.
>>>>> 5.  Modification of the Makefile.sfw and install-sfw to take into 
>>>>> account
>>>>>     the patch, removal of files that are no longer part of nmh, 
>>>>> version numbers.
>>>>> 6. Modification of the pkgproto and prototype_com files to take 
>>>>> into account
>>>>>     new version numbers and deleted files.
>>>>>
>>>>> Steve Christensen
>>>>> -- 
>>>>> This messages posted from opensolaris.org
>>>>> _______________________________________________
>>>>> companion-discuss mailing list
>>>>> companion-discuss at opensolaris.org
>>>>> http://opensolaris.org/mailman/listinfo/companion-discuss
>>>>>
>>>>
>>>
>>
>