[companion-discuss] Code Review Request: Update of SFWoldap (openldap) package

Paul Cunningham paulcun at talk21.com
Mon Jun 11 02:44:06 PDT 2007


This looks okay to me

Paul

Steve Christensen wrote:
> The is a code review request for the update of the SFWoldap (openldap) package to  version 2.3.35.
> 
> The webrev is at
> 
> http://companion.sunfreeware.com/downloads/openldapwebrev/
> 
> The changes done were:
> 
> 1.  A METADATA file added
> 2.  Removal of old source and addition of new source.
> 3.  In the Makefile.sfw, version numbers were updated, flags and paths modified so
>     that various libraries and header files are correctly located.
> 4.  In the install-sfw file, version numbers were updated, sccs lines removed, copyrights
>      updated, library versions updated, .dat files removed (no longer part of the release),
>      and other files added or removed as needed.
> 5.  In pkginfo.tmpl, version numbers were updated, sccs lines removed, and copyrights
>      updated.
> 6.  In prototype_com, copyrights were updated, sccs lines removed, files added or
>      removed where needed.
> 7.  In Targetdirs, two directories that are no longer needed were removed.
> 
> The code builds cleanly in a nightly build in NV62.
> 
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
> 



More information about the companion-discuss mailing list