[companion-discuss] Re: Code Review Request: Update of tcpdump package to current version

[Steve Christensen]

See my further comments below.

Thanks,

Steve C.


> 
> ==== Start of Comments ===================
> 
> 1. version
> Is everyone happy about including an unstable
>  version in the
> consolidation? It's okay with me though,  if it
> works.


Yes, this issue is one I have thought about also.  It seems there is a long time between official releases of tcpdump.  Since the 3.9.5  version does not build on Nevada and this newer one does, and appears to function, I ask that it be approved anyway.  If they release a new official version, we can update to that one easily.  

However, I can drop the update if there is good reason to.


> 
> 2. EXFILES and Makefile.sfw
> Should this be referenced in the Makefile.sfw (as
> per previous)

Of course, and I have now done this and updated the webrev.


> 
> 3. src/pkgdefs/SFWtdmp/prototype_com
> Nothing has changed except for the copyright
>  line, so why has
>    it been changed ?

Because I just got a bit too enthusiastic about copyright changing.  I have removed the change.


> == End of comments =====================
> 
> 
> Steve Christensen wrote:
> > This is a request for a code review for the update
> of tcpdump from the
> > 2004 version 3.8.3 to the current version released
> on 2007.03.14.
> > 
> > The webrev for this is at
> > 
> >
> http://companion.sunfreeware.com/downloads/tcpdumpwebr
> ev/
> > 
> > The version 3.8.3 currently on the Companion CD is
> now three years
> > old.  The version 3.9.5 released last year does not
> build on
> > Nevada 56.  However, the version released as
> tcpdump-current on March 14
> > builds easily on Nevada 56.  Tests show that
> tcpdump works normally for
> > both SPARC and x86 systems.  The latest libpcap
> 0.9.5 package was used
> > to perform the tcpdump compile.
> > 
> > Changes to the build files were very
> straightforward requiring only version number changes
> and the elimination of patches that are no longer
> needed.
> > 
> > The home page for tcpdump is
> http://www.tcpdump.org.
> > 
> > Steve Christensen
> > --
> > This messages posted from opensolaris.org
> > _______________________________________________
> > companion-discuss mailing list
> > companion-discuss at opensolaris.org
> >
> http://opensolaris.org/mailman/listinfo/companion-disc
> uss
> > 
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-disc
> uss
>
--
This messages posted from opensolaris.org