[companion-discuss] Re: Code Review Request: Update of file package

[Paul Cunningham]

Steve Christensen wrote:
> Paul -
> 
> The webrev has been updated to include the changes you suggest.
> 

Looks okay to me now

Paul

> 
> 
>>Steve,
>>
>>A few minor comments ....
>>
>>Paul
>>
>>==== Start Comments ====================
>>
>>1. src/cmd/file/DISTDIRS.sfw
>>did you really need to change this - its only
>> reordered the dir names
>>2. src/cmd/file/Makefile.sfw +
>>src/cmd/file/EXFILES.sfw
>>    Makefile.sfw needs changing to use EXFILES.sfw

>>==== End Comments ======================
>>
>>Steve Christensen wrote:
>>
>>>This is a code review request for the update of the
>>
>>SFWfile and SFWfileS packages to version 4.20. 
>>
>>>The webrev is at
>>>
>>>
>>
>>http://companion.sunfreeware.com/downloads/filewebrev/
>>
>>>Source files and version numbers were updated.
>>
>>Copyright files were updated where relevant. A
>>METADATA file was added.  A patch was required to
>>get a proper build.  The patch, specific to Solaris,
>>was taken from a patch created already by the file
>> developers.
>> 
>>The build on Nevada 56 was done and no errors were
>> found.
>> 
>> Steve Christensen
>> --
>> This messages posted from opensolaris.org
>> _______________________________________________
>> companion-discuss mailing list
>> companion-discuss at opensolaris.org
>> http://opensolaris.org/mailman/listinfo/companion-dis
>>uss
>>
>>_______________________________________________
>>companion-discuss mailing list
>>companion-discuss at opensolaris.org
>>http://opensolaris.org/mailman/listinfo/companion-disc
>>uss
>>
> 
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
>