[companion-discuss] Re: Code Review Request: Removal of Source Packages

[Steve Christensen]

Norm -

Thanks for the comments.  I have made the changes which are in the 
updated webrev at

http://companion.sunfreeware.com/downloads/nosourcewebrev/

See below for comments.

I have also fixed the copyright file in pkgdefs/SFWcvs which was
missing a part.


A nightly build is completely clean for NV62.

Steve C.



> Ok, I just finished going through your webrev.  I
> ignored all of the 
> removed files and only looked at the files with
> diffs.  I have a couple 
> of general comments and a few specific ones.
> 
> General comment...
> 
> in the process of unpacking tarballs in the
> various Makefile.sfw
>     files, the target often
> has:
> 
> find $(VER) -type d -exec /usr/bin/chmod 755
>  "{}" \;
> find $(VER) -type f -exec /usr/bin/chmod ugo+r
>  "{}" \;
>     I suspect that this can be removed as well.


Yes, they can be removed and I have edited all the Makefile.sfw files to do so.
This has no negative effect on the builds.


> You appear to have removed the "ident" lines from
>  the files.  Do we
> want to replace them with SubVersion ids ("$Id$")
>  instead of just
>    removing them?


If we are going to put Subversion ids into files, then it is probably easier
and more consistent to to that all at once, but I can do that file by file if
that is what you think is needed.  

> 
>     src/Makefile.master
>     You need to remove the FIXSRC= line

This has been removed and a few others suggest my Mike S.

>  src/tools/fixsrc
>        should be removed from the workspace.

Removed and a reference to fixsrc in the Makefile there also removed.

> c/lib/fnlib/Makefile.sfw
> You can remove the comments at 46-47, they no
> longer apply

Removed.

> 
> 
>     -Norm
> ve Christensen wrote:
> > It has been determined that source packages are no
> longer needed on the Companion.  This code review is
> for the removal of all code in the Companion that
> relates to the generation of such packages.  This
> involves:
> >
> > 1. Removal of the DISTDIRS.sfw, DISTFILES.sfw, and
> EXFILES.sfw files from all directories.
> > 2. The removal of the SFW...S directories in
> pkgdefs.
> > 3. The editing of the Makefile in pkgdefs to remove
> the makes of the source directories there.
> > 4. The editing of all Makefile.sfw files to remove
> anything to do with source package generation.
> > 5. The removal of other files no longer needed like
> makedist in the tools directory.
> > 6.  Updating of Copyrights where needed (hope I got
> them all).
> >
> > About 550 files were edited or deleted, so this is
> a pretty big code review I am sorry to say, but
> straightforward since most changes are much the same
> across the files.
> >
> > The webrev is at
> >
> >
> http://companion.sunfreeware.com/downloads/nosourceweb
> rev/
> >
> > A nightly build of the new code is completely clean
> with no protocmp errors.  No source packages were
> generated and the only things now in /opt/sfw/src are
> from the rpm build that needs to place a few files
> there.
> >
> > Steve Christensen
> > --
> > This messages posted from opensolaris.org
> > _______________________________________________
> > companion-discuss mailing list
> > companion-discuss at opensolaris.org
> >
> http://opensolaris.org/mailman/listinfo/companion-disc
> uss
> >   
> 
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-disc
> uss
>
--
This messages posted from opensolaris.org