[companion-discuss] Xterm updates (196 to 229) - review request

[Danek Duvall]

On Tue, Nov 13, 2007 at 06:18:57PM +0530, rahul wrote:

>     is xterm still considered for companion cd?
> (I have confirmed that it is not there for SFW as a separate
> package, but may be part of another?) If it is considered, I
> would like to update it.  Please do review

I think it's still appropriate for the CCD.  The X folks have been talking
for some time about updating it in the WOS, but they've been busy, and
nothing's happened on that front.  I'd love to see this.

 - resize.patch, menu-include.patch: Can you provide a short explanation of
   why you needed to add the former and remove the latter?  The last build
   I did was of 222, and I didn't need to make either change.

> Index: cmd/xterm/Makefile.sfw

>  all: $(VER)/config.status
>  	(cd $(VER); env \
> -	    CC=$(SRC)/tools/gcc CXX=$(SRC)/tools/g++ \
>  	    PATH=/usr/perl5/bin:/usr/sfw/bin:$(PATH) \
>  	    "LD_OPTIONS=-L/usr/sfw/lib -L$(ROOT)/opt/sfw/lib -R/usr/sfw/lib:/opt/sfw/lib" \
> -	    MAKE=/usr/sfw/bin/gmake /usr/sfw/bin/gmake)
> +	    MAKE=/usr/ccs/bin/make \
> +		/usr/ccs/bin/make 2>&1 )

Why the 2>&1?

> -	    MAKE=/usr/sfw/bin/gmake \
> -	./configure  --prefix=/opt/sfw)
> +	    MAKE=/usr/ccs/bin/make \
> +	./configure  --prefix=/opt/sfw --enable-256-colors)

Might as well use /usr/bin/make; I think the CCD is now built on a system
where that's happened.  I've also been using --enable-88-color and
--enable-wide-chars in my builds in addition to --enable-256-colors.

> Index: pkgdefs/SFWxterm/pkginfo.tmpl
> ===================================================================
> --- pkgdefs/SFWxterm/pkginfo.tmpl	(revision 145)
> +++ pkgdefs/SFWxterm/pkginfo.tmpl	(working copy)
> @@ -35,7 +35,7 @@
>  ARCH="ISA"
>  VERSION="196,REV=0.0.0"
>  SUNW_PRODNAME="xterm"
> -SUNW_PRODVERS="RELEASE/196"
> +SUNW_PRODVERS="RELEASE/229"

You missed updating VERSION.

Don't forget to update README.sfw and METADATA, too.

Thanks,
Danek