[companion-discuss] Code Review Request: Update of SFWmutt
Paul Cunningham
paul.cunningham at tadpole.com
Mon Apr 21 01:00:00 PDT 2008
Looks mainly okay to me.
But 'Copyright' year needs changing in src/Targetdirs (not that that
really matters)
Paul
Steve Christensen wrote:
> This is a code review request for the update of the SFWmutt package to version 1.5.17.
>
> The webrev is at http://companion.sunfreeware.com/downloads/muttwebrev/
>
> Details:
>
> 1. Update of source code file (using .gz since that is what the mutt site offers).
> 2. Update date in and form of copyright lines.
> 3. Remove SCCS ids where needed.
> 4. Update version numbers in METADATA, Makefile.sfw, install-sfw, pkginfo.tmpl
> 5. Manual files moved in install-sfw and prototype_com to correspond to where mutt now puts them.
> 6. Remove /opt/sfw/doc/mutt/html directory in Targetdirs file - no longer needed.
> 7. Update patch.Muttrc file to correspond to new Muttrc file.
> 8. Makefile.sfw now needs CPPFLAGS set so that idn includes in /usr/include/idn are found by configure.
>
> This builds cleanly in a nightly in NV 84 and a pkgadd installs the package properly and
> mutt works.
>
> Steve Christensen
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
General Dynamics Itronix Europe Ltd.
More information about the companion-discuss
mailing list