From sunfreeware at gmail.com  Sun Jan 13 23:42:34 2008
From: sunfreeware at gmail.com (Steve Christensen)
Date: Sun, 13 Jan 2008 23:42:34 PST
Subject: [companion-discuss] Code Review Request: Update of SFWfile package
Message-ID: <6533745.1200296609199.JavaMail.Twebapp@oss-app1>

This is a code review request for the update of the SFWfile package to version 4.23.

The webrev is at

http://companion.sunfreeware.com/downloads/filewebrev/

The changes are very simple.

1.  Update of version numbers where needed.
2.  Update of copyright dates.

A nightly build works with no errors on NV 76.

Steve Christensen
--
This messages posted from opensolaris.org


From paulcun at talk21.com  Mon Jan 14 00:11:55 2008
From: paulcun at talk21.com (paulcun at talk21.com)
Date: Mon, 14 Jan 2008 08:11:55 +0000 (GMT)
Subject: [companion-discuss] Code Review Request: Update of SFWfile
	package
In-Reply-To: <6533745.1200296609199.JavaMail.Twebapp@oss-app1>
Message-ID: <670935.43248.qm@web86508.mail.ird.yahoo.com>

Steve,

This looks okay to me

Paul


--- Steve Christensen <sunfreeware at gmail.com> wrote:

> This is a code review request for the update of the
> SFWfile package to version 4.23.
> 
> The webrev is at
> 
>
http://companion.sunfreeware.com/downloads/filewebrev/
> 
> The changes are very simple.
> 
> 1.  Update of version numbers where needed.
> 2.  Update of copyright dates.
> 
> A nightly build works with no errors on NV 76.
> 



From sunfreeware at gmail.com  Mon Jan 14 19:35:12 2008
From: sunfreeware at gmail.com (Steve Christensen)
Date: Mon, 14 Jan 2008 19:35:12 PST
Subject: [companion-discuss] Code Review Request: Update of the SFWpftpd
	(proftpd) Package
Message-ID: <7342485.1200368157431.JavaMail.Twebapp@oss-app1>

This is a code review request for the update of the SFWpftpd (proftpd) package to version 
1.3.1.

The webrev is at http://companion.sunfreeware.com/downloads/proftpdwebrev/

Details:

1.  Version numbers updated where needed.
2.  Copyright year updated in various files.
3.  SCCS id lines removed.
4.  Source file updated.
5.  Patch that is no longer needed removed.

A nightly build is OK on NV 76.  The package installs properly with no errors
and appears to produce working programs.

Steve Christensen
--
This messages posted from opensolaris.org


From Norm.Jacobs at Sun.COM  Mon Jan 14 22:15:36 2008
From: Norm.Jacobs at Sun.COM (Norm Jacobs)
Date: Tue, 15 Jan 2008 00:15:36 -0600
Subject: [companion-discuss] Code Review Request: Update of the SFWpftpd
 (proftpd) Package
In-Reply-To: <7342485.1200368157431.JavaMail.Twebapp@oss-app1>
References: <7342485.1200368157431.JavaMail.Twebapp@oss-app1>
Message-ID: <478C4F88.1090203@Sun.COM>


It looks ok to me.

       -Norm

Steve Christensen wrote:
> This is a code review request for the update of the SFWpftpd (proftpd) package to version 
> 1.3.1.
>
> The webrev is at http://companion.sunfreeware.com/downloads/proftpdwebrev/
>
> Details:
>
> 1.  Version numbers updated where needed.
> 2.  Copyright year updated in various files.
> 3.  SCCS id lines removed.
> 4.  Source file updated.
> 5.  Patch that is no longer needed removed.
>
> A nightly build is OK on NV 76.  The package installs properly with no errors
> and appears to produce working programs.
>
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/companion-discuss
>   



From sunfreeware at gmail.com  Mon Jan 14 23:41:28 2008
From: sunfreeware at gmail.com (Steve Christensen)
Date: Mon, 14 Jan 2008 23:41:28 PST
Subject: [companion-discuss] Code Review Request: Update of SFWtclx and
	SFWexpct Packages
Message-ID: <3193428.1200383157957.JavaMail.Twebapp@oss-app1>

This is a resubmission of a code review request for the updates of the SFWtclx (tclx) and
SFWexpect (expect) packages.  Note that expect will shortly be part of Nevada and will then be
removed from the Companion.  For now, the update was done so that a full nightly build could
be finished.

Tcl and Tk source directories are added as both tclx and expect need the
source to build.

The webrev is at

http://companion.sunfreeware.com/downloads/tclxexpectwebrev/

Details -

1. Source code files updated.
2. METADATA files added.
3. The Tcl and Tk directories are there only to supply source code availability.
4. Version numbers and Copyrights updated where needed.
5. ./configure options modified to point to the correct tcl and tk source directories.
6. prototype_com and pkginfo.tmpl modified with new files and directories.
7. Various patches removed that are no longer needed and new patch created.
8. Targetdirs and Makefiles updated to deal with tcl and tk source directories and tclx directories.

This builds with no problems or errors on NV 76.

Steve Christensen
--
This messages posted from opensolaris.org


From paulcun at talk21.com  Mon Jan 14 23:53:42 2008
From: paulcun at talk21.com (paulcun at talk21.com)
Date: Tue, 15 Jan 2008 07:53:42 +0000 (GMT)
Subject: [companion-discuss] Code Review Request: Update of the SFWpftpd
	(proftpd) Package
In-Reply-To: <7342485.1200368157431.JavaMail.Twebapp@oss-app1>
Message-ID: <154527.69894.qm@web86511.mail.ird.yahoo.com>

... and it looks okay to me to
Paul

--- Steve Christensen <sunfreeware at gmail.com> wrote:

> This is a code review request for the update of the
> SFWpftpd (proftpd) package to version 
> 1.3.1.
> 
> The webrev is at
>
http://companion.sunfreeware.com/downloads/proftpdwebrev/
> 
> Details:
> 
> 1.  Version numbers updated where needed.
> 2.  Copyright year updated in various files.
> 3.  SCCS id lines removed.
> 4.  Source file updated.
> 5.  Patch that is no longer needed removed.
> 
> A nightly build is OK on NV 76.  The package
> installs properly with no errors
> and appears to produce working programs.
> 
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
>
http://mail.opensolaris.org/mailman/listinfo/companion-discuss
> 



From paulcun at talk21.com  Tue Jan 15 00:12:57 2008
From: paulcun at talk21.com (paulcun at talk21.com)
Date: Tue, 15 Jan 2008 08:12:57 +0000 (GMT)
Subject: [companion-discuss] Code Review Request: Update of SFWtclx and
	SFWexpct Packages
In-Reply-To: <3193428.1200383157957.JavaMail.Twebapp@oss-app1>
Message-ID: <895369.81834.qm@web86515.mail.ird.yahoo.com>

Steve,

This looks okay to me - very minor comment: the
"Copyright" year needs updating to 2008 in lots of the
changed files.

Paul

--- Steve Christensen <sunfreeware at gmail.com> wrote:

> This is a resubmission of a code review request for
> the updates of the SFWtclx (tclx) and
> SFWexpect (expect) packages.  Note that expect will
> shortly be part of Nevada and will then be
> removed from the Companion.  For now, the update was
> done so that a full nightly build could
> be finished.
> 
> Tcl and Tk source directories are added as both tclx
> and expect need the
> source to build.
> 
> The webrev is at
> 
>
http://companion.sunfreeware.com/downloads/tclxexpectwebrev/
> 
> Details -
> 
> 1. Source code files updated.
> 2. METADATA files added.
> 3. The Tcl and Tk directories are there only to
> supply source code availability.
> 4. Version numbers and Copyrights updated where
> needed.
> 5. ./configure options modified to point to the
> correct tcl and tk source directories.
> 6. prototype_com and pkginfo.tmpl modified with new
> files and directories.
> 7. Various patches removed that are no longer needed
> and new patch created.
> 8. Targetdirs and Makefiles updated to deal with tcl
> and tk source directories and tclx directories.
> 
> This builds with no problems or errors on NV 76.
> 
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
>
http://mail.opensolaris.org/mailman/listinfo/companion-discuss
> 



From steve at smc.vnet.net  Tue Jan 15 00:15:06 2008
From: steve at smc.vnet.net (Steve Christensen)
Date: Tue, 15 Jan 2008 03:15:06 -0500
Subject: [companion-discuss] Code Review Request: Update of SFWtclx and
 SFWexpct Packages
In-Reply-To: <895369.81834.qm@web86515.mail.ird.yahoo.com>
References: <895369.81834.qm@web86515.mail.ird.yahoo.com>
Message-ID: <478C6B8A.4090504@smc.vnet.net>

Paul -

Actually all the changes were made to the files in 2007 so I did not
do 2008.   I presume it is OK to leave them at 2007.

Steve C.

paulcun at talk21.com wrote:
> Steve,
> 
> This looks okay to me - very minor comment: the
> "Copyright" year needs updating to 2008 in lots of the
> changed files.
> 
> Paul
> 
> --- Steve Christensen <sunfreeware at gmail.com> wrote:
> 
>> This is a resubmission of a code review request for
>> the updates of the SFWtclx (tclx) and
>> SFWexpect (expect) packages.  Note that expect will
>> shortly be part of Nevada and will then be
>> removed from the Companion.  For now, the update was
>> done so that a full nightly build could
>> be finished.
>>
>> Tcl and Tk source directories are added as both tclx
>> and expect need the
>> source to build.
>>
>> The webrev is at
>>
>>
> http://companion.sunfreeware.com/downloads/tclxexpectwebrev/
>> Details -
>>
>> 1. Source code files updated.
>> 2. METADATA files added.
>> 3. The Tcl and Tk directories are there only to
>> supply source code availability.
>> 4. Version numbers and Copyrights updated where
>> needed.
>> 5. ./configure options modified to point to the
>> correct tcl and tk source directories.
>> 6. prototype_com and pkginfo.tmpl modified with new
>> files and directories.
>> 7. Various patches removed that are no longer needed
>> and new patch created.
>> 8. Targetdirs and Makefiles updated to deal with tcl
>> and tk source directories and tclx directories.
>>
>> This builds with no problems or errors on NV 76.
>>
>> Steve Christensen
>> --
>> This messages posted from opensolaris.org
>> _______________________________________________
>> companion-discuss mailing list
>> companion-discuss at opensolaris.org
>>
> http://mail.opensolaris.org/mailman/listinfo/companion-discuss
> 
> 


From paulcun at talk21.com  Tue Jan 15 00:27:40 2008
From: paulcun at talk21.com (paulcun at talk21.com)
Date: Tue, 15 Jan 2008 08:27:40 +0000 (GMT)
Subject: [companion-discuss] Code Review Request: Update of SFWtclx and
	SFWexpct Packages
In-Reply-To: <478C6B8A.4090504@smc.vnet.net>
Message-ID: <487237.39958.qm@web86502.mail.ird.yahoo.com>


--- Steve Christensen <steve at smc.vnet.net> wrote:

> Paul -
> 
> Actually all the changes were made to the files in
> 2007 so I did not
> do 2008.   I presume it is OK to leave them at 2007.

It's okay with me (hence 'very minor comment'), but in
terms of the 'gate' the the change will be made in
2008. But feel free to ignore as its only cosmetic
anyway :-)

Paul

> 
> paulcun at talk21.com wrote:
> > Steve,
> > 
> > This looks okay to me - very minor comment: the
> > "Copyright" year needs updating to 2008 in lots of
> the
> > changed files.
> > 
> > Paul
> > 
> > --- Steve Christensen <sunfreeware at gmail.com>
> wrote:
> > 
> >> This is a resubmission of a code review request
> for
> >> the updates of the SFWtclx (tclx) and
> >> SFWexpect (expect) packages.  Note that expect
> will
> >> shortly be part of Nevada and will then be
> >> removed from the Companion.  For now, the update
> was
> >> done so that a full nightly build could
> >> be finished.
> >>
> >> Tcl and Tk source directories are added as both
> tclx
> >> and expect need the
> >> source to build.
> >>
> >> The webrev is at
> >>
> >>
> >
>
http://companion.sunfreeware.com/downloads/tclxexpectwebrev/
> >> Details -
> >>
> >> 1. Source code files updated.
> >> 2. METADATA files added.
> >> 3. The Tcl and Tk directories are there only to
> >> supply source code availability.
> >> 4. Version numbers and Copyrights updated where
> >> needed.
> >> 5. ./configure options modified to point to the
> >> correct tcl and tk source directories.
> >> 6. prototype_com and pkginfo.tmpl modified with
> new
> >> files and directories.
> >> 7. Various patches removed that are no longer
> needed
> >> and new patch created.
> >> 8. Targetdirs and Makefiles updated to deal with
> tcl
> >> and tk source directories and tclx directories.
> >>
> >> This builds with no problems or errors on NV 76.
> >>
> >> Steve Christensen
> >> --
> >> This messages posted from opensolaris.org
> >> _______________________________________________
> >> companion-discuss mailing list
> >> companion-discuss at opensolaris.org
> >>
> >
>
http://mail.opensolaris.org/mailman/listinfo/companion-discuss
> > 
> > 
> 



From steve at smc.vnet.net  Tue Jan 15 01:03:30 2008
From: steve at smc.vnet.net (Steve Christensen)
Date: Tue, 15 Jan 2008 04:03:30 -0500
Subject: [companion-discuss] Code Review Request: Update of SFWtclx and
 SFWexpct Packages
In-Reply-To: <487237.39958.qm@web86502.mail.ird.yahoo.com>
References: <487237.39958.qm@web86502.mail.ird.yahoo.com>
Message-ID: <478C76E2.1060407@smc.vnet.net>

I guess someone will need to tell me what the rule is.  Should the date 
be when the file was modified or when it is put into the gate?  I can 
certainly change the dates.

Steve C.

paulcun at talk21.com wrote:
> --- Steve Christensen <steve at smc.vnet.net> wrote:
> 
>> Paul -
>>
>> Actually all the changes were made to the files in
>> 2007 so I did not
>> do 2008.   I presume it is OK to leave them at 2007.
> 
> It's okay with me (hence 'very minor comment'), but in
> terms of the 'gate' the the change will be made in
> 2008. But feel free to ignore as its only cosmetic
> anyway :-)
> 
> Paul
> 
>> paulcun at talk21.com wrote:
>>> Steve,
>>>
>>> This looks okay to me - very minor comment: the
>>> "Copyright" year needs updating to 2008 in lots of
>> the
>>> changed files.
>>>
>>> Paul
>>>
>>> --- Steve Christensen <sunfreeware at gmail.com>
>> wrote:
>>>> This is a resubmission of a code review request
>> for
>>>> the updates of the SFWtclx (tclx) and
>>>> SFWexpect (expect) packages.  Note that expect
>> will
>>>> shortly be part of Nevada and will then be
>>>> removed from the Companion.  For now, the update
>> was
>>>> done so that a full nightly build could
>>>> be finished.
>>>>
>>>> Tcl and Tk source directories are added as both
>> tclx
>>>> and expect need the
>>>> source to build.
>>>>
>>>> The webrev is at
>>>>
>>>>
> http://companion.sunfreeware.com/downloads/tclxexpectwebrev/
>>>> Details -
>>>>
>>>> 1. Source code files updated.
>>>> 2. METADATA files added.
>>>> 3. The Tcl and Tk directories are there only to
>>>> supply source code availability.
>>>> 4. Version numbers and Copyrights updated where
>>>> needed.
>>>> 5. ./configure options modified to point to the
>>>> correct tcl and tk source directories.
>>>> 6. prototype_com and pkginfo.tmpl modified with
>> new
>>>> files and directories.
>>>> 7. Various patches removed that are no longer
>> needed
>>>> and new patch created.
>>>> 8. Targetdirs and Makefiles updated to deal with
>> tcl
>>>> and tk source directories and tclx directories.
>>>>
>>>> This builds with no problems or errors on NV 76.
>>>>
>>>> Steve Christensen
>>>> --
>>>> This messages posted from opensolaris.org
>>>> _______________________________________________
>>>> companion-discuss mailing list
>>>> companion-discuss at opensolaris.org
>>>>
> http://mail.opensolaris.org/mailman/listinfo/companion-discuss
>>>
> 
> 


From danek.duvall at sun.com  Tue Jan 15 09:16:53 2008
From: danek.duvall at sun.com (Danek Duvall)
Date: Tue, 15 Jan 2008 09:16:53 -0800
Subject: [companion-discuss] Code Review Request: Update of SFWtclx
	and	SFWexpct Packages
In-Reply-To: <478C76E2.1060407@smc.vnet.net>
References: <487237.39958.qm@web86502.mail.ird.yahoo.com>
	<478C76E2.1060407@smc.vnet.net>
Message-ID: <20080115171653.GP1882@zruty.sfbay.sun.com>

On Tue, Jan 15, 2008 at 04:03:30AM -0500, Steve Christensen wrote:

> I guess someone will need to tell me what the rule is.  Should the date 
> be when the file was modified or when it is put into the gate?  I can 
> certainly change the dates.

ON's been following the rule of when the code is changed, not when it's
putback.  But I don't think it matters too terribly much one way or the
other.

Danek


From sunfreeware at gmail.com  Sat Jan 19 00:40:59 2008
From: sunfreeware at gmail.com (Steve Christensen)
Date: Sat, 19 Jan 2008 00:40:59 PST
Subject: [companion-discuss] Code Review Request: Update of SFWmutt and
	SFWslang Packages
Message-ID: <3505809.1200732118885.JavaMail.Twebapp@oss-app1>

This is a code review request for updates of the SFWmutt and SFWslang packages.

These are done together because mutt will not build with the previous slang package version.

The webrev is at

http://companion.sunfreeware.com/downloads/muttslangwebrev/

Details:

1.  Source code files updated and .gz compression replaced with .bz2.
2.  Copyrights updated to 2008 and sccs ids removed where needed.
3.  Mutt METADATA file added and slang METADATA file updated.
4.  patch.Muttrc file updated for most recent Muttrc file.
5.  Some slang library files that are no longer created removed from prototype_com file.
6.  Library file names updated.
7.  Version numbers updated where needed.
8.  Web sites in pkginfo.tmpl and METADATA files updated if needed.

The changed files work in a nightly build with no errors on NV 76.  Packages install properly and mutt program starts up normally.

Steve Christensen
--
This messages posted from opensolaris.org


From paulcun at talk21.com  Mon Jan 21 00:07:21 2008
From: paulcun at talk21.com (paulcun at talk21.com)
Date: Mon, 21 Jan 2008 08:07:21 +0000 (GMT)
Subject: [companion-discuss] Code Review Request: Update of SFWmutt and
	SFWslang Packages
In-Reply-To: <3505809.1200732118885.JavaMail.Twebapp@oss-app1>
Message-ID: <757880.79743.qm@web86501.mail.ird.yahoo.com>

The changes look good to me

Paul


--- Steve Christensen <sunfreeware at gmail.com> wrote:

> This is a code review request for updates of the
> SFWmutt and SFWslang packages.
> 
> These are done together because mutt will not build
> with the previous slang package version.
> 
> The webrev is at
> 
>
http://companion.sunfreeware.com/downloads/muttslangwebrev/
> 
> Details:
> 
> 1.  Source code files updated and .gz compression
> replaced with .bz2.
> 2.  Copyrights updated to 2008 and sccs ids removed
> where needed.
> 3.  Mutt METADATA file added and slang METADATA file
> updated.
> 4.  patch.Muttrc file updated for most recent Muttrc
> file.
> 5.  Some slang library files that are no longer
> created removed from prototype_com file.
> 6.  Library file names updated.
> 7.  Version numbers updated where needed.
> 8.  Web sites in pkginfo.tmpl and METADATA files
> updated if needed.
> 
> The changed files work in a nightly build with no
> errors on NV 76.  Packages install properly and mutt
> program starts up normally.
> 
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
>
http://mail.opensolaris.org/mailman/listinfo/companion-discuss
>