From sunfreeware at gmail.com Tue Jul 1 00:11:23 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 01 Jul 2008 00:11:23 PDT Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 235 Message-ID: <31429182.1214896342214.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWxterm package to version 235. The webrev is at http://companion.sunfreeware.com/downloads/xtermwebrev/ This update is trivial and done just to keep the xterm version at its most recent release level. The only changes are the xterm source file and the version number in the various files. This builds cleanly in NV87 with no issues and produces a working xterm. Steve Christensen -- This messages posted from opensolaris.org From Paul.Cunningham at tadpole.com Tue Jul 1 00:25:47 2008 From: Paul.Cunningham at tadpole.com (Cunningham, Paul - UK) Date: Tue, 1 Jul 2008 00:25:47 -0700 Subject: [companion-discuss] Code Review Request: Update of SFWxterm toversion 235 In-Reply-To: <31429182.1214896342214.JavaMail.Twebapp@oss-app1> References: <31429182.1214896342214.JavaMail.Twebapp@oss-app1> Message-ID: <22D2A03452AD8042AB763199CEFE9D03091098@exchange.tadpole.tad> Steve, This looks good to me Paul > -----Original Message----- > From: companion-discuss-bounces at opensolaris.org > [mailto:companion-discuss-bounces at opensolaris.org] On Behalf > Of Steve Christensen > Sent: 01 July 2008 08:11 > To: companion-discuss at opensolaris.org > Subject: [companion-discuss] Code Review Request: Update of > SFWxterm toversion 235 > > This is a code review request for the update of the SFWxterm > package to version 235. > > The webrev is at > > http://companion.sunfreeware.com/downloads/xtermwebrev/ > > This update is trivial and done just to keep the xterm > version at its most recent release level. > The only changes are the xterm source file and the version > number in the various files. > > This builds cleanly in NV87 with no issues and produces a > working xterm. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss > From sunfreeware at gmail.com Tue Jul 1 03:44:17 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 01 Jul 2008 03:44:17 PDT Subject: [companion-discuss] Code Review Request: Update of SFWsgrep to version 1.94a Message-ID: <5755815.1214909241873.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWsgrep package to version 1.94a. The webrev is at http://companion.sunfreeware.com/downloads/sgrepwebrev/ Details: 1. Source code file updated. 2. Copyright forms and dates updated. 3. Version numbers updates where needed. 4. METADATA file added. A nightly build is clean and produces a working sgrep in NV 87. Steve Christensen -- This messages posted from opensolaris.org From Paul.Cunningham at tadpole.com Tue Jul 1 05:11:43 2008 From: Paul.Cunningham at tadpole.com (Cunningham, Paul - UK) Date: Tue, 1 Jul 2008 05:11:43 -0700 Subject: [companion-discuss] Code Review Request: Update of SFWsgrep toversion 1.94a In-Reply-To: <5755815.1214909241873.JavaMail.Twebapp@oss-app1> References: <5755815.1214909241873.JavaMail.Twebapp@oss-app1> Message-ID: <22D2A03452AD8042AB763199CEFE9D0309109E@exchange.tadpole.tad> This looks okay to me Paul > -----Original Message----- > From: companion-discuss-bounces at opensolaris.org > [mailto:companion-discuss-bounces at opensolaris.org] On Behalf > Of Steve Christensen > Sent: 01 July 2008 11:44 > To: companion-discuss at opensolaris.org > Subject: [companion-discuss] Code Review Request: Update of > SFWsgrep toversion 1.94a > > This is a code review request for the update of the SFWsgrep > package to version 1.94a. > > The webrev is at > > http://companion.sunfreeware.com/downloads/sgrepwebrev/ > > Details: > > 1. Source code file updated. > 2. Copyright forms and dates updated. > 3. Version numbers updates where needed. > 4. METADATA file added. > > A nightly build is clean and produces a working sgrep in NV 87. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss > From Alan.Coopersmith at Sun.COM Tue Jul 1 08:16:41 2008 From: Alan.Coopersmith at Sun.COM (Alan Coopersmith) Date: Tue, 01 Jul 2008 08:16:41 -0700 Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 235 In-Reply-To: <31429182.1214896342214.JavaMail.Twebapp@oss-app1> References: <31429182.1214896342214.JavaMail.Twebapp@oss-app1> Message-ID: <486A4A59.2070700@sun.com> Steve Christensen wrote: > This is a code review request for the update of the SFWxterm package to version 235. Which is the same version we now deliver as /usr/X11/bin/xterm in nv_91 and later, though SFWxterm would still be useful for S10 & earlier Nevada users. -- -Alan Coopersmith- alan.coopersmith at sun.com Sun Microsystems, Inc. - X Window System Engineering From sunfreeware at gmail.com Tue Jul 8 04:22:13 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 08 Jul 2008 04:22:13 PDT Subject: [companion-discuss] Code Review Request: Update of SFWaalib Package Message-ID: <4141186.1215516204429.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWaalib package to version 1.4rc5. The webrev is at http://companion.sunfreeware.com/downloads/aalibwebrev/ Main Details: 1. Update source code file. 2. Update copyrights. 3. Added METADATA file. 4. Minor patch to one file so that the proper aalib.h file is found. 5. Version numbers updated where needed. 6. install-sfw and prototype_com files updated with new libraries and man pages. Builds properly in a nightly on NV87. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Wed Jul 9 01:31:55 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Wed, 09 Jul 2008 09:31:55 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWaalib Package In-Reply-To: <4141186.1215516204429.JavaMail.Twebapp@oss-app1> References: <4141186.1215516204429.JavaMail.Twebapp@oss-app1> Message-ID: <1215592315.19152.26.camel@colosunray.tadpole.tad> Steve, A few comments, see below; other than those it looks okay to me. ... Paul On Tue, 2008-07-08 at 12:22, Steve Christensen wrote: > This is a code review request for the update of the SFWaalib package to version 1.4rc5. > > The webrev is at > > http://companion.sunfreeware.com/downloads/aalibwebrev/ > > Main Details: > > 1. Update source code file. > 2. Update copyrights. > 3. Added METADATA file. > 4. Minor patch to one file so that the proper aalib.h file is found. > 5. Version numbers updated where needed. > 6. install-sfw and prototype_com files updated with new libraries and man pages. > > Builds properly in a nightly on NV87. === Start of comments === 1. src/lib/aalib/install-sfw Could you have used '_install ? ...' instead if the multiply lines, rm/cp/chmod ? You seem to have remove the 'Copyright' lines completely === End of comments ===== From sunfreeware at gmail.com Mon Jul 14 22:52:55 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 14 Jul 2008 22:52:55 PDT Subject: [companion-discuss] Code Review Request: Update of SFWmpage package Message-ID: <3826927.1216101242899.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWmpage package to version 2.5.6 and a complete redo of the build structure. The webrev is at http://companion.sunfreeware.com/downloads/mpagewebrev/ Details: 1. All of the original source files are deleted to create a structure similar to other packages. 2. The new source file is added. 3. METADATA file updated. 4. Makefile.sfw completely redone. 5. install-sfw file created. 6. The mpage source has no configure file, so in order to set up the parameters for the build to match previous builds, a patch to the mpage Makefile was created. 7. Copyrights updated where needed. 8. SCCS ids removed where needed. 9. One new encoding file added to prototype_com. 10. Version numbers updated where needed. 11. Web site updated in METADATA and pkginfo.tmpl. 12. Targetdirs file updated to include the /opt/sfw/lib/mpage directory. This builds cleanly in a nightly in NV87 and produces a working mpage package. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Wed Jul 16 00:04:51 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Wed, 16 Jul 2008 08:04:51 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWmpage package In-Reply-To: <3826927.1216101242899.JavaMail.Twebapp@oss-app1> References: <3826927.1216101242899.JavaMail.Twebapp@oss-app1> Message-ID: <1216191891.13556.17.camel@colosunray.tadpole.tad> Steve, See comments below ... Paul On Tue, 2008-07-15 at 06:52, Steve Christensen wrote: > This is a code review request for the update of the SFWmpage package to version 2.5.6 and a complete redo of the build structure. The webrev is at > > http://companion.sunfreeware.com/downloads/mpagewebrev/ > > Details: > > 1. All of the original source files are deleted to create a structure similar to other packages. > 2. The new source file is added. > 3. METADATA file updated. > 4. Makefile.sfw completely redone. > 5. install-sfw file created. > 6. The mpage source has no configure file, so in order to set up the parameters for > the build to match previous builds, a patch to the mpage Makefile was created. > 7. Copyrights updated where needed. > 8. SCCS ids removed where needed. > 9. One new encoding file added to prototype_com. > 10. Version numbers updated where needed. > 11. Web site updated in METADATA and pkginfo.tmpl. > 12. Targetdirs file updated to include the /opt/sfw/lib/mpage directory. > > This builds cleanly in a nightly in NV87 and produces a working mpage package. === Start of Comments === 1. src/cmd/mpage/install-sfw On line .. "40 _install E mpage ${PREFIX}/bin/mpage 555" you could have used just ${BINDIR}/mpage. 2. Every thing else looks okay me === End of Comments ===== From sunfreeware at gmail.com Mon Jul 21 22:49:53 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 21 Jul 2008 22:49:53 PDT Subject: [companion-discuss] Code Review Request: Update of SFWxcpus (xcpustate) package Message-ID: <22091146.1216706308317.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWxcpus (xcpustate) package to version 2.9 and a complete redo of the build structure. The webrev is at http://companion.sunfreeware.com/downloads/xcpustatewebrev/ Details: 1. All old files were eliminated to clear the build structure. 2. METADATA file added. 3. New Makefile.sfw file added. xcpustate has no configure step. A patch was created to properly setup the Makefile.noimake file. 4. Copyrights and version numbers updated where needed. 5. New install-sfw file created. 6. New source code file added. This builds properly in NV 87, the package installs correctly, and produces a working xcpustate program. Steve Christensen -- This messages posted from opensolaris.org From sunfreeware at gmail.com Tue Jul 29 14:18:44 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 29 Jul 2008 14:18:44 PDT Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 236 Message-ID: <25172265.1217366404393.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWxterm package to version 236. The webrev is at http://companion.sunfreeware.com/downloads/xtermwebrev/ This update is trivial and done just to keep the xterm version at its most recent release level. The only changes are the xterm source file and the version number in the various files. This is primarily for use in the update of the Solaris 10 Companion. This builds cleanly in a nightly build with no issues and produces a working xterm package. Steve Christensen -- This messages posted from opensolaris.org