From sunfreeware at gmail.com Mon Jun 2 22:05:43 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 02 Jun 2008 22:05:43 PDT Subject: [companion-discuss] Code Review Request: Update of Amanda Package Message-ID: <17006304.1212471117048.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWamnda (amanda) package to version 2.6.0p1. The webrev is at http://companion.sunfreeware.com/downloads/amandawebrev/ Details: There are a considerable number of changes between the older version of amanda and this new one. Details: 1. Source code file updated. 2. Version numbers updated where needed. 3. New directories added to Targetdirs to match new locations for files. 4. x_postinstall script edited to point to new file locations. 5. Copyright year updated where needed. 6. Amanda's configure fails utterly unless LD_LIBRARY_PATH is set so that it can find certain libraries. Therefore, it is set in Makefile.sfw. 7. README.amanda updated to point to new file locations. 8. prototype_com and install-sfw files required a lot of changes due to new files or file locations. A nightly build on NV 87 is clean and the package installs properly. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Tue Jun 3 05:04:02 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 03 Jun 2008 13:04:02 +0100 Subject: [companion-discuss] Code Review Request: Update of Amanda Package In-Reply-To: <17006304.1212471117048.JavaMail.Twebapp@oss-app1> References: <17006304.1212471117048.JavaMail.Twebapp@oss-app1> Message-ID: <48453332.3010805@tadpole.com> Hi Steve, This looks good to me Paul Steve Christensen wrote: > This is a code review request for the update of the SFWamnda (amanda) package to version 2.6.0p1. > > The webrev is at > > http://companion.sunfreeware.com/downloads/amandawebrev/ > > Details: > > There are a considerable number of changes between the older version of amanda and this new one. > > Details: > > 1. Source code file updated. > 2. Version numbers updated where needed. > 3. New directories added to Targetdirs to match new locations for files. > 4. x_postinstall script edited to point to new file locations. > 5. Copyright year updated where needed. > 6. Amanda's configure fails utterly unless LD_LIBRARY_PATH is set so that it > can find certain libraries. Therefore, it is set in Makefile.sfw. > 7. README.amanda updated to point to new file locations. > 8. prototype_com and install-sfw files required a lot of changes due to new files or file locations. > > > A nightly build on NV 87 is clean and the package installs properly. > > Steve Christensen -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products From sunfreeware at gmail.com Tue Jun 10 02:11:35 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 10 Jun 2008 02:11:35 PDT Subject: [companion-discuss] Code Review Request: Update of SFWcvs Package Message-ID: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> This is a code review request for the update of SFWcvs to version 1.11.23. The webrev is at http://companion.sunfreeware.com/downloads/cvswebrev/ Details: 1. Added a METADATA file. 2. Updated version numbers and copyright dates where needed. 3. Added new source file. 4. Removed SCCS ids and .SUFFIXES: line. This simple update builds cleanly in NV 87, the package installs properly, and creates a working cvs system. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Tue Jun 10 03:36:10 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 10 Jun 2008 11:36:10 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWcvs Package In-Reply-To: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> References: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> Message-ID: <1213094170.14966.120.camel@colosunray.tadpole.tad> Steve, On Tue, 2008-06-10 at 10:11, Steve Christensen wrote: > This is a code review request for the update of SFWcvs to version 1.11.23. > > The webrev is at > > http://companion.sunfreeware.com/downloads/cvswebrev/ > > Details: > > 1. Added a METADATA file. > 2. Updated version numbers and copyright dates where needed. > 3. Added new source file. > 4. Removed SCCS ids and .SUFFIXES: line. > > This simple update builds cleanly in NV 87, the package installs properly, and > creates a working cvs system. This looks okay to me, you may want to change the VENDOR= url to be the same as that in the METADATA file though. Paul From paul.cunningham at tadpole.com Tue Jun 10 03:38:59 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 10 Jun 2008 11:38:59 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWcvs Package In-Reply-To: <1213094170.14966.120.camel@colosunray.tadpole.tad> References: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> <1213094170.14966.120.camel@colosunray.tadpole.tad> Message-ID: <1213094339.14966.122.camel@colosunray.tadpole.tad> On Tue, 2008-06-10 at 11:36, Paul Cunningham wrote: > Steve, > > On Tue, 2008-06-10 at 10:11, Steve Christensen wrote: > > This is a code review request for the update of SFWcvs to version 1.11.23. > > > > The webrev is at > > > > http://companion.sunfreeware.com/downloads/cvswebrev/ > > > > Details: > > > > 1. Added a METADATA file. > > 2. Updated version numbers and copyright dates where needed. > > 3. Added new source file. > > 4. Removed SCCS ids and .SUFFIXES: line. > > > > This simple update builds cleanly in NV 87, the package installs properly, and > > creates a working cvs system. > > This looks okay to me, you may want to change the VENDOR= url to be the > same as that in the METADATA file though. in the src/pkgdefs/SFWcvs/pkginfo.tmpl file that is. Paul -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products From ro at techfak.uni-bielefeld.de Tue Jun 10 05:20:03 2008 From: ro at techfak.uni-bielefeld.de (Rainer Orth) Date: 10 Jun 2008 14:20:03 +0200 Subject: [companion-discuss] Code Review Request: Update of SFWcvs Package In-Reply-To: Steve Christensen's message of "Tue, 10 Jun 2008 02:11:35 PDT" References: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> Message-ID: Steve Christensen writes: > This is a code review request for the update of SFWcvs to version 1.11.23. What's the benefit of this if CVS 1.12.13 is already in sfwnv? Rainer -- ----------------------------------------------------------------------------- Rainer Orth, Faculty of Technology, Bielefeld University From sunfreeware at gmail.com Tue Jun 10 13:58:42 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Tue, 10 Jun 2008 16:58:42 -0400 Subject: [companion-discuss] Code Review Request: Update of SFWcvs Package In-Reply-To: References: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> Message-ID: <484EEB02.30806@gmail.com> The packages in the Companion are also for Solaris 10 U4, U5, and eventually U6. CVS may be in SFWNV now, but is not or may not be for those releases. It is easy to take something off the Companion, but once removed, it is not always so easy to put it back if needed. So, for now, I am continuing to update it. Steve C. Rainer Orth wrote: > Steve Christensen writes: > >> This is a code review request for the update of SFWcvs to version 1.11.23. > > What's the benefit of this if CVS 1.12.13 is already in sfwnv? > > Rainer > From sunfreeware at gmail.com Tue Jun 10 15:22:42 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 10 Jun 2008 15:22:42 PDT Subject: [companion-discuss] Code Review Request: Update of SFWtnef Package Message-ID: <25874673.1213136617039.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWtnef package to version 1.4.4. The webrev is at http://companion.sunfreeware.com/downloads/tnefwebrev/ Details: 1. Updated version number and copyright year where needed. 2. Bring in new source code file. 3. Minor update to source URL. This is a simple update which builds cleanly in NV87, creates a package that installs properly, and functions normally. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Wed Jun 11 00:55:58 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Wed, 11 Jun 2008 08:55:58 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWtnef Package In-Reply-To: <25874673.1213136617039.JavaMail.Twebapp@oss-app1> References: <25874673.1213136617039.JavaMail.Twebapp@oss-app1> Message-ID: <1213170958.14309.22.camel@colosunray.tadpole.tad> Steve, This looks good to me Paul On Tue, 2008-06-10 at 23:22, Steve Christensen wrote: > This is a code review request for the update of the SFWtnef package to version 1.4.4. > > The webrev is at > > http://companion.sunfreeware.com/downloads/tnefwebrev/ > > Details: > > 1. Updated version number and copyright year where needed. > 2. Bring in new source code file. > 3. Minor update to source URL. > > This is a simple update which builds cleanly in NV87, creates a package that > installs properly, and functions normally. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss From ro at techfak.uni-bielefeld.de Wed Jun 11 09:47:14 2008 From: ro at techfak.uni-bielefeld.de (Rainer Orth) Date: Wed, 11 Jun 2008 18:47:14 +0200 (MEST) Subject: [companion-discuss] Code Review Request: Update of SFWcvs Package In-Reply-To: <484EEB02.30806@gmail.com> References: <11745445.1213089182456.JavaMail.Twebapp@oss-app1> <484EEB02.30806@gmail.com> Message-ID: <18512.402.695763.832584@manam.TechFak.Uni-Bielefeld.DE> Steven M. Christensen writes: > The packages in the Companion are also for Solaris 10 U4, U5, and > eventually U6. CVS may be in SFWNV now, but is not or may not be for > those releases. It is easy to take something off the Companion, but > once removed, it is not always so easy to put it back if needed. So, > for now, I am continuing to update it. thanks for the clarification. I had thought that the companion consolidation (like sfwnv) were for Nevada only. Rainer ----------------------------------------------------------------------------- Rainer Orth, Faculty of Technology, Bielefeld University From sunfreeware at gmail.com Mon Jun 16 15:55:06 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 16 Jun 2008 15:55:06 PDT Subject: [companion-discuss] Code Review Request: Update of SFWxdelta Package Message-ID: <16461253.1213657911930.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the SFWxdelta package to version 1.1.4. The webrev is at http://companion.sunfreeware.com/downloads/xdeltawebrev/ Details: This is a very simple update of the Version 1 track of xdelta. 1. METADATA file added. 2. Source code file updated. 3. Version number and copyright year updated where needed. 4. SCCS ids removed. This builds properly in a nightly in NV 87. The package installs properly producing a working xdelta system. Steve Christensen -- This messages posted from opensolaris.org From Paul.Cunningham at tadpole.com Tue Jun 17 00:17:31 2008 From: Paul.Cunningham at tadpole.com (Cunningham, Paul - UK) Date: Tue, 17 Jun 2008 00:17:31 -0700 Subject: [companion-discuss] Code Review Request: Update of SFWxdelta Package In-Reply-To: <16461253.1213657911930.JavaMail.Twebapp@oss-app1> References: <16461253.1213657911930.JavaMail.Twebapp@oss-app1> Message-ID: <22D2A03452AD8042AB763199CEFE9D03091044@exchange.tadpole.tad> Steve, This looks good to me Paul -----Original Message----- From: companion-discuss-bounces at opensolaris.org [mailto:companion-discuss-bounces at opensolaris.org] On Behalf Of Steve Christensen Sent: 16 June 2008 15:55 To: companion-discuss at opensolaris.org Subject: [companion-discuss] Code Review Request: Update of SFWxdelta Package This is a code review request for the update of the SFWxdelta package to version 1.1.4. The webrev is at http://companion.sunfreeware.com/downloads/xdeltawebrev/ Details: This is a very simple update of the Version 1 track of xdelta. 1. METADATA file added. 2. Source code file updated. 3. Version number and copyright year updated where needed. 4. SCCS ids removed. This builds properly in a nightly in NV 87. The package installs properly producing a working xdelta system. Steve Christensen -- This messages posted from opensolaris.org _______________________________________________ companion-discuss mailing list companion-discuss at opensolaris.org http://mail.opensolaris.org/mailman/listinfo/companion-discuss From sunfreeware at gmail.com Mon Jun 30 02:09:02 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 30 Jun 2008 02:09:02 PDT Subject: [companion-discuss] Code Review Request: Update of SFWfltk to version 1.1.9 Message-ID: <22366784.1214817030004.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the ftlk package to version 1.1.9 from release candidate 2 of 1.1.9. The webrev for this very simple update is at http://companion.sunfreeware.com/downloads/fltkwebrev/ Details: 1. Source code file updated. 2. Version numbers updated where needed. The nightly is clean on NV87, a test pkgadd works, and the programs appear to run normally. Steve Christensen -- This messages posted from opensolaris.org From Paul.Cunningham at tadpole.com Mon Jun 30 07:05:42 2008 From: Paul.Cunningham at tadpole.com (Cunningham, Paul - UK) Date: Mon, 30 Jun 2008 07:05:42 -0700 Subject: [companion-discuss] Code Review Request: Update of SFWfltk toversion 1.1.9 In-Reply-To: <22366784.1214817030004.JavaMail.Twebapp@oss-app1> References: <22366784.1214817030004.JavaMail.Twebapp@oss-app1> Message-ID: <22D2A03452AD8042AB763199CEFE9D03091094@exchange.tadpole.tad> Steve, This looks okay to me Paul > -----Original Message----- > From: companion-discuss-bounces at opensolaris.org > [mailto:companion-discuss-bounces at opensolaris.org] On Behalf > Of Steve Christensen > Sent: 30 June 2008 10:09 > To: companion-discuss at opensolaris.org > Subject: [companion-discuss] Code Review Request: Update of > SFWfltk toversion 1.1.9 > > This is a code review request for the update of the ftlk > package to version 1.1.9 from release candidate 2 of 1.1.9. > The webrev for this very simple update is at > > http://companion.sunfreeware.com/downloads/fltkwebrev/ > > Details: > > 1. Source code file updated. > 2. Version numbers updated where needed. > > The nightly is clean on NV87, a test pkgadd works, and the > programs appear to run normally. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss >