From sunfreeware at gmail.com Mon Mar 17 22:19:34 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 17 Mar 2008 22:19:34 PDT Subject: [companion-discuss] Code Review Request: Minor fix to xmms build Message-ID: <25709723.1205817751038.JavaMail.Twebapp@oss-app1> This is a code review request for a minor fix to the build of the xmms package. The configure step is now finding a fts.h file in recent versions of Nevada and this breaks the build. The patch here removes the problem and a nightly in NV 84 for SPARC and x86 now works with no problem. http://companion.sunfreeware.com/downloads/xmmswebrev/ Steve Christensen -- This messages posted from opensolaris.org From paulcun at talk21.com Tue Mar 18 00:56:58 2008 From: paulcun at talk21.com (Paul Cunningham) Date: Tue, 18 Mar 2008 00:56:58 PDT Subject: [companion-discuss] Code Review Request: Minor fix to xmms build In-Reply-To: <25709723.1205817751038.JavaMail.Twebapp@oss-app1> Message-ID: <31302733.1205827048119.JavaMail.Twebapp@oss-app2> Steve, > This is a code review request for a minor fix to the > build of the xmms package. > The configure step is now finding a fts.h file in > recent versions of Nevada and this > breaks the build. The patch here removes the > problem and a nightly in NV 84 for SPARC > and x86 now works with no problem. > > http://companion.sunfreeware.com/downloads/xmmswebrev/ This looks okay to me. But just a thought, could 'fts' have been taken out by using a 'configure' option telling it not to use 'fts', which may have been better than patching it (maybe). Paul (PS. I had to switch to my tadpole.com email address as I can no longer get to my talk21.com email at work :-( ). -- This messages posted from opensolaris.org From sunfreeware at gmail.com Tue Mar 18 02:05:39 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Tue, 18 Mar 2008 05:05:39 -0400 Subject: [companion-discuss] Code Review Request: Minor fix to xmms build In-Reply-To: <31302733.1205827048119.JavaMail.Twebapp@oss-app2> References: <31302733.1205827048119.JavaMail.Twebapp@oss-app2> Message-ID: <47DF85E3.9000000@gmail.com> Paul - I did try that in various ways and in no case did configure pick up the way to turn off fts.h. The patch was the only thing I could figure out. I may have missed something obvious. Steve C. Paul Cunningham wrote: > Steve, > >> This is a code review request for a minor fix to the >> build of the xmms package. >> The configure step is now finding a fts.h file in >> recent versions of Nevada and this >> breaks the build. The patch here removes the >> problem and a nightly in NV 84 for SPARC >> and x86 now works with no problem. >> >> http://companion.sunfreeware.com/downloads/xmmswebrev/ > > This looks okay to me. But just a thought, could 'fts' have been taken out by using a 'configure' option telling it not to use 'fts', which may have been better than patching it (maybe). > > Paul (PS. I had to switch to my tadpole.com email address as I can no longer get to my talk21.com email at work :-( ). > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss > From paul.cunningham at tadpole.com Tue Mar 18 02:20:19 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 18 Mar 2008 09:20:19 +0000 Subject: [companion-discuss] Code Review Request: Minor fix to xmms build In-Reply-To: <47DF85E3.9000000@gmail.com> References: <31302733.1205827048119.JavaMail.Twebapp@oss-app2> <47DF85E3.9000000@gmail.com> Message-ID: <47DF8953.1070502@tadpole.com> Steven M. Christensen wrote: > > I did try that in various ways and in no case did configure pick up > the way to turn off fts.h. The patch was the only thing I could figure > out. I may have missed something obvious. Sorry I can't help there without actually looking at it. So just go with the patch (Unless someone else knows better). Paul > > Paul Cunningham wrote: > >>Steve, >> >> >>>This is a code review request for a minor fix to the >>>build of the xmms package. >>>The configure step is now finding a fts.h file in >>>recent versions of Nevada and this >>>breaks the build. The patch here removes the >>>problem and a nightly in NV 84 for SPARC >>>and x86 now works with no problem. >>> >>>http://companion.sunfreeware.com/downloads/xmmswebrev/ >> >>This looks okay to me. But just a thought, could 'fts' have been taken out by using a 'configure' option telling it not to use 'fts', which may have been better than patching it (maybe). >> >>Paul (PS. I had to switch to my tadpole.com email address as I can no longer get to my talk21.com email at work :-( ). >>-- >>This messages posted from opensolaris.org >>_______________________________________________ >>companion-discuss mailing list >>companion-discuss at opensolaris.org >>http://mail.opensolaris.org/mailman/listinfo/companion-discuss >> > > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message From sunfreeware at gmail.com Mon Mar 24 02:09:55 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 24 Mar 2008 02:09:55 PDT Subject: [companion-discuss] Code Review Request: Update of SFWnpbm (netpbm) Package Message-ID: <3949097.1206350070422.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the netpbm package from version 10.3 to version 10.26.51 (the latest version as of this date). The webrev is at http://companion.sunfreeware.com/downloads/netpbmwebrev/ Details: 1. Copyright dates updated to 2008 where required. 2. SCCS ids removed. 3. METADATA file added. 4. Source code file updated and version numbers fixed in various files. 5. Patches changed to correspond to most recent files. 6. SUFFIXES line removed from Makefile.sfw. 7. A number of programs have been removed in this version and those are removed from install-sfw and prototype_com. Library version updated. 8. Locations of some built files have changed and this is fixed in install-sfw. These changes build correctly and a pkgadd of the new package produces working programs. This was done on NV 81. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Tue Mar 25 04:13:32 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 25 Mar 2008 11:13:32 +0000 Subject: [companion-discuss] Code Review Request: Update of SFWnpbm (netpbm) Package In-Reply-To: <3949097.1206350070422.JavaMail.Twebapp@oss-app1> References: <3949097.1206350070422.JavaMail.Twebapp@oss-app1> Message-ID: <47E8DE5C.2090808@tadpole.com> Steve, Steve Christensen wrote: > This is a code review request for the update of the netpbm package from version 10.3 to version 10.26.51 (the latest version as of this date). The webrev is at > > http://companion.sunfreeware.com/downloads/netpbmwebrev/ This update looks okay to me Paul > > Details: > > 1. Copyright dates updated to 2008 where required. > 2. SCCS ids removed. > 3. METADATA file added. > 4. Source code file updated and version numbers fixed in various files. > 5. Patches changed to correspond to most recent files. > 6. SUFFIXES line removed from Makefile.sfw. > 7. A number of programs have been removed in this version and those are > removed from install-sfw and prototype_com. Library version updated. > 8. Locations of some built files have changed and this is fixed in install-sfw. > > These changes build correctly and a pkgadd of the new package produces working programs. > This was done on NV 81. > > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message From sunfreeware at gmail.com Sat Mar 29 14:11:05 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Sat, 29 Mar 2008 14:11:05 PDT Subject: [companion-discuss] Code Review Request: Update of SFWyasr Package Message-ID: <13771308.1206825120278.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the yasr package to version 0.6.9 (the latest version). This is a simple version change. The webrev is at http://companion.sunfreeware.com/downloads/yasrwebrev/ Details: 1. Updated source file from 0.6.7 to 0.6.9. 2. Updated copyright year where needed. 3. Added METADATA file. 4. minor update to patch to correspond to new yasr.conf file. 5. Removed SUFFIXES line from Makefile.sfw. 6. Updated version number where needed. A full nightly build in NV84 is clean and a pkgadd of SFWyasr works. Steve Christensen -- This messages posted from opensolaris.org From sunfreeware at gmail.com Sun Mar 30 20:40:38 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Sun, 30 Mar 2008 20:40:38 PDT Subject: [companion-discuss] Code Review Request: Update of SFWxterm Packages Message-ID: <12836470.1206934918617.JavaMail.Twebapp@oss-app1> This is a code review request for the update of the xterm Companion package from version 229 to version 234 (the current version). The webrev is at http://companion.sunfreeware.com/downloads/xtermwebrev/ Details: 1. Source file updated to version 234. 2. METADATA file updated. 3. Copyright year updated where needed. 4. SCCS ids removed. 5. Version numbers updated in Makefile.sfw, install-sfw, pkginfo.tmpl files. 6. resize patch no longer needed so it has been removed and its use in Makefile.sfw removed. 7. menu-include.patch updated and expanded to include more changes of menu.h locations. 8. uxterm.patch updated to correspond to new uxterm file. The new code builds cleanly on NV 84 and a pkgadd creates a working xterm. One issue that might still need to be addressed is that when xterm is started, the following message appears - input method doesn't support my preedit type (OverTheSpot,Root) This is a known issue with xterm and can be dealt with in three ways 1. Ignore it as it does not affect the use of xterm. 2. Recompile xterm with --disable-i18n. 3. The xterm FAQ says that when this message appears - input method doesn't support my preedit type Ignore this if you do not know what input method is. Input methods are used to enter composite characters (e.g., umlauts, other types of punctuated characters, East Asian characters, etc). Your computer's libraries support this, but are missing configuration tables, and xterm is warning you. If the message bothers you (e.g., if you aren't starting xterm from a window manager menu), you can suppress it by setting a resource: XTerm*openIm:false I am open to suggestions on what solution to use. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Mon Mar 31 00:44:25 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Mon, 31 Mar 2008 08:44:25 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWyasr Package In-Reply-To: <13771308.1206825120278.JavaMail.Twebapp@oss-app1> References: <13771308.1206825120278.JavaMail.Twebapp@oss-app1> Message-ID: <47F09659.1020602@tadpole.com> This looks good to me Paul Steve Christensen wrote: > This is a code review request for the update of the yasr package to version 0.6.9 (the latest version). This is a simple version change. > > The webrev is at > > http://companion.sunfreeware.com/downloads/yasrwebrev/ > > Details: > > 1. Updated source file from 0.6.7 to 0.6.9. > 2. Updated copyright year where needed. > 3. Added METADATA file. > 4. minor update to patch to correspond to new yasr.conf file. > 5. Removed SUFFIXES line from Makefile.sfw. > 6. Updated version number where needed. > > A full nightly build in NV84 is clean and a pkgadd of SFWyasr works. > From paul.cunningham at tadpole.com Mon Mar 31 06:14:40 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Mon, 31 Mar 2008 14:14:40 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWxterm Packages In-Reply-To: <12836470.1206934918617.JavaMail.Twebapp@oss-app1> References: <12836470.1206934918617.JavaMail.Twebapp@oss-app1> Message-ID: <47F0E3C0.90602@tadpole.com> Just the one comment, see below: otherwise it looks okay to me I have not preference on how you deal with the "known issue", but maybe whatever you do should be put in README.SFWxterm. Paul ===== Comments ====================== 1. src/cmd/xterm/uxterm.patch is the XTERM_PROGRAM= /usr path correct? ===== End comments ================== Steve Christensen wrote: > This is a code review request for the update of the xterm Companion package from version 229 to version 234 (the current version). > > The webrev is at > > http://companion.sunfreeware.com/downloads/xtermwebrev/ > > Details: > > 1. Source file updated to version 234. > 2. METADATA file updated. > 3. Copyright year updated where needed. > 4. SCCS ids removed. > 5. Version numbers updated in Makefile.sfw, install-sfw, pkginfo.tmpl files. > 6. resize patch no longer needed so it has been removed and its use in Makefile.sfw removed. > 7. menu-include.patch updated and expanded to include more changes of menu.h locations. > 8. uxterm.patch updated to correspond to new uxterm file. > > The new code builds cleanly on NV 84 and a pkgadd creates a working xterm. > > One issue that might still need to be addressed is that when xterm is started, the following > message appears - > > input method doesn't support my preedit type (OverTheSpot,Root) > > This is a known issue with xterm and can be dealt with in three ways > > 1. Ignore it as it does not affect the use of xterm. > 2. Recompile xterm with --disable-i18n. > 3. The xterm FAQ says that when this message appears - > > input method doesn't support my preedit type > Ignore this if you do not know what input method is. Input methods are used to enter composite characters (e.g., umlauts, other types of punctuated characters, East Asian characters, etc). Your computer's libraries support this, but are missing configuration tables, and xterm is warning you. > > If the message bothers you (e.g., if you aren't starting xterm from a window manager menu), you can suppress it by setting a resource: > > > XTerm*openIm:false > > > I am open to suggestions on what solution to use. > From sunfreeware at gmail.com Mon Mar 31 15:14:57 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 31 Mar 2008 15:14:57 PDT Subject: [companion-discuss] Code Review Request: Update of SFWxterm Packages In-Reply-To: <47F0E3C0.90602@tadpole.com> Message-ID: <506286.1207001743977.JavaMail.Twebapp@oss-app1> Paul - Thanks for the suggestion. I have added a README.SFWxterm file with some comments about the startup message xterm gives and added the appropriate changes to Makefile.sfw and prototype_com so that this file installs in the usual place. The new webrev is at http://companion.sunfreeware.com/downloads/xtermwebrev/ Let me know if this is OK. Steve C. > Just the one comment, see below: otherwise it looks > okay to me > > I have not preference on how you deal with the "known > issue", but maybe > whatever you do should be put in README.SFWxterm. > > Paul > > ===== Comments ====================== > > 1. src/cmd/xterm/uxterm.patch > is the XTERM_PROGRAM= /usr path correct? > == End comments ================== > > > Steve Christensen wrote: > > This is a code review request for the update of the > xterm Companion package from version 229 to version > 234 (the current version). > > > > The webrev is at > > > > > http://companion.sunfreeware.com/downloads/xtermwebrev > / > > > > Details: > > > > 1. Source file updated to version 234. > > 2. METADATA file updated. > > 3. Copyright year updated where needed. > > 4. SCCS ids removed. > > 5. Version numbers updated in Makefile.sfw, > install-sfw, pkginfo.tmpl files. > > 6. resize patch no longer needed so it has been > removed and its use in Makefile.sfw removed. > > 7. menu-include.patch updated and expanded to > include more changes of menu.h locations. > > 8. uxterm.patch updated to correspond to new uxterm > file. > > > > The new code builds cleanly on NV 84 and a pkgadd > creates a working xterm. > > > > One issue that might still need to be addressed is > that when xterm is started, the following > > message appears - > > > > input method doesn't support my preedit type > (OverTheSpot,Root) > > > > This is a known issue with xterm and can be dealt > with in three ways > > > > 1. Ignore it as it does not affect the use of > xterm. > > 2. Recompile xterm with --disable-i18n. > > 3. The xterm FAQ says that when this message > appears - > > > > input method doesn't support my preedit type > > Ignore this if you do not know what input > method is. Input methods are used to enter composite > characters (e.g., umlauts, other types of punctuated > characters, East Asian characters, etc). Your > computer's libraries support this, but are missing > configuration tables, and xterm is warning you. > > > > If the message bothers you (e.g., if you aren't > starting xterm from a window manager menu), you can > suppress it by setting a resource: > > > > > > XTerm*openIm:false > > > > > > I am open to suggestions on what solution to use. > > > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion > -discuss -- This messages posted from opensolaris.org