From sunfreeware at gmail.com Sun May 4 02:03:48 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Sun, 04 May 2008 02:03:48 PDT Subject: [companion-discuss] Code Review Request: Bug fix for xmms Message-ID: <13609470.1209891933738.JavaMail.Twebapp@oss-app1> Andy Barna has reported a bug in the current xmms package such that when the Random is clicked, the program seg faults. He and Laca at Sun have provided a patch to fix this. The webrev is at http://companion.sunfreeware.com/downloads/xmmswebrev/ which includes the new patch and a modified Makefile.sfw. This builds properly and as far as I can see, clicking Random does not crash the program. Steve Christensen -- This messages posted from opensolaris.org From sunfreeware at gmail.com Tue May 6 20:13:49 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 06 May 2008 20:13:49 PDT Subject: [companion-discuss] Code Review Request: Update of lynx package Message-ID: <10019710.1210130109148.JavaMail.Twebapp@oss-app2> This is a code review request for the update of the SFWlynx package to version 2.8.6. The webrev is at http://companion.sunfreeware.com/downloads/lynxwebrev/ Details: 1. Updated source package - using .bz2 compression since the main site offers that now. 2. Updated Copyright dates in changed files where needed. 3. Removed SCCS ids where they appear. 4. Added METADATA file. 5. Updated patch file to point to new source version directory. 6. Modified Makefile.sfw configure to point to lynx.cfg and lynx.lss file correctly. Removed SUFFIXES line. 7. Modified install-sfw file to install lynx.lss file. 8. Updated version number, copyright, and VENDOR site in pkginfo.tmpl. 9. Add new doc files and modified some file names in prototype_com file. This builds cleanly in a Nevada 87 nightly build. The package installs properly and creates a working lynx system. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Tue May 6 23:55:27 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Wed, 07 May 2008 07:55:27 +0100 Subject: [companion-discuss] Code Review Request: Update of lynx package In-Reply-To: <10019710.1210130109148.JavaMail.Twebapp@oss-app2> References: <10019710.1210130109148.JavaMail.Twebapp@oss-app2> Message-ID: <4821525F.2070203@tadpole.com> Steve, This looks good to me Paul Steve Christensen wrote: > This is a code review request for the update of the SFWlynx package to version 2.8.6. The webrev is at > > http://companion.sunfreeware.com/downloads/lynxwebrev/ > > Details: > > 1. Updated source package - using .bz2 compression since the main site offers that now. > 2. Updated Copyright dates in changed files where needed. > 3. Removed SCCS ids where they appear. > 4. Added METADATA file. > 5. Updated patch file to point to new source version directory. > 6. Modified Makefile.sfw configure to point to lynx.cfg and lynx.lss file correctly. Removed > SUFFIXES line. > 7. Modified install-sfw file to install lynx.lss file. > 8. Updated version number, copyright, and VENDOR site in pkginfo.tmpl. > 9. Add new doc files and modified some file names in prototype_com file. > > This builds cleanly in a Nevada 87 nightly build. The package installs properly and creates a working lynx system. > > Steve Christensen > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message From sunfreeware at gmail.com Mon May 12 23:56:21 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 12 May 2008 23:56:21 PDT Subject: [companion-discuss] Code Review Request: Update of SFWsudo Package Message-ID: <13430878.1210661828178.JavaMail.Twebapp@oss-app1> This is a code review request for the simple update of the SFWsudo package to version 1.6.9p16. The webrev is at http://companion.sunfreeware.com/downloads/sudowebrev/ Only minor changes were needed - 1. Source file updated. Using .gz since that is what the main site offers. 2. Version numbers updated where needed. A nightly build is clean and produces a working sudo package. Steve Christensen -- This messages posted from opensolaris.org From paul.cunningham at tadpole.com Tue May 13 00:48:01 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 13 May 2008 08:48:01 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWsudo Package In-Reply-To: <13430878.1210661828178.JavaMail.Twebapp@oss-app1> References: <13430878.1210661828178.JavaMail.Twebapp@oss-app1> Message-ID: <482947B1.20600@tadpole.com> Hi Steve, This looks okay to me Paul Steve Christensen wrote: > This is a code review request for the simple update of the SFWsudo package to version 1.6.9p16. The webrev is at > > http://companion.sunfreeware.com/downloads/sudowebrev/ > > Only minor changes were needed - > > 1. Source file updated. Using .gz since that is what the main site offers. > 2. Version numbers updated where needed. > > A nightly build is clean and produces a working sudo package. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products