From sunfreeware at gmail.com Sat Sep 13 00:36:44 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Sat, 13 Sep 2008 00:36:44 PDT Subject: [companion-discuss] Code Review Request: Update of SFWfile package Message-ID: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> This is a code review request for the update of the SFWfile package to version 4.26. The webrev is at http://companion.sunfreeware.com/downloads/filewebrev Details - 1. Source file updated. gzip compression now used since that is what is offered on the file web site. 2. Version numbers and copyright dates updated where needed. SCCS ids removed. 3. Three files in the old version are no longer needed and have been removed in install-sfw and prototype_com. The nightly build on Nevada is clean. Test installation of the package works producing a valid gfile program. Steve Christensen -- This message posted from opensolaris.org From Milan.Jurik at Sun.COM Sun Sep 14 02:22:36 2008 From: Milan.Jurik at Sun.COM (Milan Jurik) Date: Sun, 14 Sep 2008 11:22:36 +0200 Subject: [companion-discuss] Code Review Request: Update of SFWfile package In-Reply-To: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> References: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> Message-ID: <1221384156.1216.5.camel@xylabone> Hi Steve, Steve Christensen p????e v so 13. 09. 2008 v 00:36 -0700: > This is a code review request for the update of the SFWfile package to version 4.26. The webrev is at > > http://companion.sunfreeware.com/downloads/filewebrev > > Details - > > 1. Source file updated. gzip compression now used since that is what is offered on the file > web site. > 2. Version numbers and copyright dates updated where needed. SCCS ids removed. Did companion move to Mercurial already? > 3. Three files in the old version are no longer needed and have been removed in install-sfw and prototype_com. > > The nightly build on Nevada is clean. Test installation of the package works producing > a valid gfile program. > Best regards, Milan From sunfreeware at gmail.com Sun Sep 14 03:15:19 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Sun, 14 Sep 2008 06:15:19 -0400 Subject: [companion-discuss] Code Review Request: Update of SFWfile package In-Reply-To: <1221384156.1216.5.camel@xylabone> References: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> <1221384156.1216.5.camel@xylabone> Message-ID: <48CCE437.1090504@gmail.com> No, it is still in subversion, but I do plan to try the move to mercurial at some point soon. Steve C. Milan Jurik wrote: > Hi Steve, > > Steve Christensen p????e v so 13. 09. 2008 v 00:36 -0700: >> This is a code review request for the update of the SFWfile package to version 4.26. The webrev is at >> >> http://companion.sunfreeware.com/downloads/filewebrev >> >> Details - >> >> 1. Source file updated. gzip compression now used since that is what is offered on the file >> web site. >> 2. Version numbers and copyright dates updated where needed. SCCS ids removed. > > Did companion move to Mercurial already? > >> 3. Three files in the old version are no longer needed and have been removed in install-sfw and prototype_com. >> >> The nightly build on Nevada is clean. Test installation of the package works producing >> a valid gfile program. >> > > Best regards, > > Milan > > From Milan.Jurik at Sun.COM Sun Sep 14 06:51:14 2008 From: Milan.Jurik at Sun.COM (Milan Jurik) Date: Sun, 14 Sep 2008 15:51:14 +0200 Subject: [companion-discuss] Code Review Request: Update of SFWfile package In-Reply-To: <48CCE437.1090504@gmail.com> References: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> <1221384156.1216.5.camel@xylabone> <48CCE437.1090504@gmail.com> Message-ID: <1221400275.2106.3.camel@xylabone> Hi Steve, ah, yes, it's svn. I looked at your changes and it looks OK for me, but I haven't PaulC's experience. Best regards, Milan Steven M. Christensen p????e v ne 14. 09. 2008 v 06:15 -0400: > No, it is still in subversion, but I do plan to try the move to > mercurial at some point soon. > > Steve C. > > > > Milan Jurik wrote: > > Hi Steve, > > > > Steve Christensen p????????e v so 13. 09. 2008 v 00:36 -0700: > >> This is a code review request for the update of the SFWfile package to version 4.26. The webrev is at > >> > >> http://companion.sunfreeware.com/downloads/filewebrev > >> > >> Details - > >> > >> 1. Source file updated. gzip compression now used since that is what is offered on the file > >> web site. > >> 2. Version numbers and copyright dates updated where needed. SCCS ids removed. > > > > Did companion move to Mercurial already? > > > >> 3. Three files in the old version are no longer needed and have been removed in install-sfw and prototype_com. > >> > >> The nightly build on Nevada is clean. Test installation of the package works producing > >> a valid gfile program. > >> > > > > Best regards, > > > > Milan > > > > > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/companion-discuss From sunfreeware at gmail.com Sun Sep 14 22:15:17 2008 From: sunfreeware at gmail.com (Steve Christensen) Date: Sun, 14 Sep 2008 22:15:17 PDT Subject: [companion-discuss] Code Review Request: Update of SFWslang and SFWslrn Packages Message-ID: <11544484.11771221455748238.JavaMail.Twebapp@sf-app1> This is a code review request for the update of the SFWslang package to version 2.1.4 and the SFWslrn package to version 0.9.9. These are connected since slrn depends on the slang version. The webrev is at http://companion.sunfreeware.com/downloads/slrnslangwebrev/ Details: 1. Version numbers and Copyright dates updated where needed. 2. New source files added. Old ones removed. 3. In the slrn install-sfw file, the new build locations of slrn and slrnpull binaries are changed. 4. Library version numbers updated in slang prototype_com. 5. Two new slrn files added in prototype_com. These packages build cleanly in Nevada. The packages install correctly and produce a working slrn binary. Steve Christensen -- This message posted from opensolaris.org From paul.cunningham at tadpole.com Mon Sep 15 00:24:38 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Mon, 15 Sep 2008 08:24:38 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWfile package In-Reply-To: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> References: <15816142.15421221291434727.JavaMail.Twebapp@sf-app1> Message-ID: <48CE0DB6.7010402@tadpole.com> Looks okay to me to Paul Steve Christensen wrote: > This is a code review request for the update of the SFWfile package to version 4.26. The webrev is at > > http://companion.sunfreeware.com/downloads/filewebrev > > Details - > > 1. Source file updated. gzip compression now used since that is what is offered on the file > web site. > 2. Version numbers and copyright dates updated where needed. SCCS ids removed. > 3. Three files in the old version are no longer needed and have been removed in install-sfw and prototype_com. > > The nightly build on Nevada is clean. Test installation of the package works producing > a valid gfile program. > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products From paul.cunningham at tadpole.com Mon Sep 15 00:36:56 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Mon, 15 Sep 2008 08:36:56 +0100 Subject: [companion-discuss] Code Review Request: Update of SFWslang and SFWslrn Packages In-Reply-To: <11544484.11771221455748238.JavaMail.Twebapp@sf-app1> References: <11544484.11771221455748238.JavaMail.Twebapp@sf-app1> Message-ID: <48CE1098.60208@tadpole.com> Steve, Just one very minor comment (see below), everything else looks okay to me. Paul Steve Christensen wrote: > This is a code review request for the update of the SFWslang package to version 2.1.4 and the SFWslrn package to version 0.9.9. These are connected since slrn depends on the slang version. > > The webrev is at > > http://companion.sunfreeware.com/downloads/slrnslangwebrev/ > > Details: > > 1. Version numbers and Copyright dates updated where needed. > 2. New source files added. Old ones removed. > 3. In the slrn install-sfw file, the new build locations of slrn and slrnpull binaries are changed. > 4. Library version numbers updated in slang prototype_com. > 5. Two new slrn files added in prototype_com. > > These packages build cleanly in Nevada. The packages install correctly and produce a working slrn binary. === Start of Comments ==== 1. src/pkgdefs/SFWslrn/prototype_com Copyright year is wrong === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products From paul.cunningham at tadpole.com Tue Sep 16 02:59:38 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 16 Sep 2008 10:59:38 +0100 Subject: [companion-discuss] SFWnmh update? In-Reply-To: <48CF7A5D.4000708@gmail.com> References: <48CF6D21.6040702@gmail.com> <48CF70A5.2080208@tadpole.com> <48CF7A5D.4000708@gmail.com> Message-ID: <48CF838A.3000101@tadpole.com> Steve, Looks mainly okay to me, just a very minor comment (which you left just to catch me out :-) ) ... Paul Steven M. Christensen wrote: > This is a code review request for the update of the SFWnmh package to > version 1.3. > > The webrev is at > > http://companion.sunfreeware.com/downloads/nmhwebrev/ > > Details: > > 1. Update of source code file. > 2. Version number changes in METADATA, install-sfw, Makefile.sfw, and > pkginfo.tmpl > 3. Copyright year updated where needed. > 4. Several files moved or deleted with changes from 1.2 to 1.3. > > This builds cleanly in Nevada, the package installs properly, and > produces a working set of programs. === Start of Comments === 1. src/pkgdefs/SFWnmh/prototype_com Copyright year is wrong 2. src/cmd/nmh/Makefile.sfw Format of copyright line - remove '(c)' === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products From paul.cunningham at tadpole.com Tue Sep 23 02:38:40 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 23 Sep 2008 10:38:40 +0100 Subject: [companion-discuss] SFWxterm code review In-Reply-To: <48D8259D.4000704@gmail.com> References: <48D8259D.4000704@gmail.com> Message-ID: <48D8B920.2040100@tadpole.com> Steve, This looks okay to me. Paul Steven M. Christensen wrote: > > This is a code review request for the update of the SFWxterm package to > version 237. > > The webrev is at > > http://companion.sunfreeware.com/downloads/xtermwebrev/ > > The changes are the xterm source file and the version number in the > various files. One > unneeded patch is removed. As before, this will be used in future > updates of > the Solaris 10 CCD. > > This builds cleanly in a nightly build with no issues and produces a > working xterm package. > > Steve Christensen > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products From paul.cunningham at tadpole.com Tue Sep 30 06:14:49 2008 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 30 Sep 2008 14:14:49 +0100 Subject: [companion-discuss] Code Review for SFWmutt In-Reply-To: <48E20379.9000700@gmail.com> References: <48E20379.9000700@gmail.com> Message-ID: <48E22649.9060603@tadpole.com> Steve, This looks okay to me Paul Steven M. Christensen wrote: > > This is a code review request for the update of the SFWmutt package to > version 1.5.18. The webrev is at > > http://companion.sunfreeware.com/downloads/muttwebrev/ > > Details: > > 1. Version number updated where neeeded. > 2. New source file added. > 3. patch file updated. > 4. Minor fix to install-sfw to fix location of Muttrc file. > > This builds cleanly in Nevada and after pkgadd produces a working mutt > system. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products