From sunfreeware at gmail.com  Mon Feb 16 13:52:50 2009
From: sunfreeware at gmail.com (Steve Christensen)
Date: Mon, 16 Feb 2009 13:52:50 PST
Subject: [companion-discuss] Code Review Request: Update of SFWxterm to
	version 242
Message-ID: <1105446858.131234821206339.JavaMail.Twebapp@sf-app1>

This is a code review request for the simple update of SFWxterm to version 242.  The webrev is at

http://companion.sunfreeware.com/downloads/xtermwebrev/

Details:

1. Update of source code file.
2. Update of version numbers in all relevant files.

A usual build produces a working xterm package.

Steve Christensen
-- 
This message posted from opensolaris.org


From paul.cunningham at tadpole.com  Tue Feb 17 00:00:02 2009
From: paul.cunningham at tadpole.com (Paul Cunningham)
Date: Tue, 17 Feb 2009 08:00:02 +0000
Subject: [companion-discuss] Code Review Request: Update of SFWxterm to
 version 242
In-Reply-To: <1105446858.131234821206339.JavaMail.Twebapp@sf-app1>
References: <1105446858.131234821206339.JavaMail.Twebapp@sf-app1>
Message-ID: <499A6E82.30906@tadpole.com>

Steve,

This looks good to me.

Just wondering though if you could save yourself a bit a work in pkg 
version updates in the future by handling the pkg name and version 
number in the same way as the sfwnv gate does now. ie. using macros ...
    VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
to extract it from the METADATA, as in ...
"http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/meld/Makefile.sfw"
"http://src.opensolaris.org/source/xref/sfw/usr/src/Makefile.master"
but that does mean extra work initially though.
And also then passing the version/name from Makefile.sfw into install-sfw.
  - Just a thought.

Paul

Steve Christensen wrote:
> This is a code review request for the simple update of SFWxterm to version 242.  The webrev is at
> 
> http://companion.sunfreeware.com/downloads/xtermwebrev/
> 
> Details:
> 
> 1. Update of source code file.
> 2. Update of version numbers in all relevant files.
> 
> A usual build produces a working xterm package.
> 
> Steve Christensen

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit