From sunfreeware at gmail.com Tue Jan 6 02:43:46 2009 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 06 Jan 2009 02:43:46 PST Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 238 Message-ID: <989421257.481231238656367.JavaMail.Twebapp@sf-app1> This is a code review request for the update of the SFWxterm package to version 238. The webrev is at http://companion.sunfreeware.com/downloads/xtermwebrev/ This is another simple update where only the version numbers, copyright dates, and METADATA file are updated. The build is fine creating a working xterm package. Steve Christensen -- This message posted from opensolaris.org From sunfreeware at gmail.com Tue Jan 6 02:52:56 2009 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 06 Jan 2009 02:52:56 PST Subject: [companion-discuss] Code Review Request: Update of SFWenscr Package Message-ID: <1610890509.611231239206687.JavaMail.Twebapp@sf-app1> This is a code review request for the update of the SFWenscr package to version 1.6.4. The webrev is at http://companion.sunfreeware.com/downloads/enscriptwebrev/ Details: 1. METADATA file added. 2. Copyright dates and version numbers updated where needed. 3. Source file updated. 4. One CC line in Makefile.sfw removed as this causes a failed build due to a known bug in the configure file for 1.6.4. 5. fi language files removed in prototype_com since these do not exist in 1.6.4. 6. Various file locations fixed in install-sfw. The package builds cleanly and produces a working SFWenscr package. Steve Christensen -- This message posted from opensolaris.org From paul.cunningham at tadpole.com Tue Jan 6 02:58:34 2009 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 06 Jan 2009 10:58:34 +0000 Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 238 In-Reply-To: <989421257.481231238656367.JavaMail.Twebapp@sf-app1> References: <989421257.481231238656367.JavaMail.Twebapp@sf-app1> Message-ID: <4963395A.9060006@tadpole.com> Steve, Looks good, but a couple of very minor comments ... Paul Steve Christensen wrote: > This is a code review request for the update of the SFWxterm package to version 238. The webrev is at > > http://companion.sunfreeware.com/downloads/xtermwebrev/ > > This is another simple update where only the version numbers, copyright dates, and METADATA file are updated. The build is fine creating a working xterm package. 1. src/cmd/xterm/METADATA Change lower case characters ... bugtRAQ: ---> BUGTRAQ: 2. src/cmd/xterm/README.SFWxterm webrev says "No differences encountered" (so has it changed?) -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit From paul.cunningham at tadpole.com Tue Jan 6 03:09:47 2009 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 06 Jan 2009 11:09:47 +0000 Subject: [companion-discuss] Code Review Request: Update of SFWenscr Package In-Reply-To: <1610890509.611231239206687.JavaMail.Twebapp@sf-app1> References: <1610890509.611231239206687.JavaMail.Twebapp@sf-app1> Message-ID: <49633BFB.1080909@tadpole.com> Steve, Also looks good to me, just a very minor comments .. Paul Steve Christensen wrote: > This is a code review request for the update of the SFWenscr package to version 1.6.4. The webrev is at > > http://companion.sunfreeware.com/downloads/enscriptwebrev/ > > Details: > > 1. METADATA file added. > 2. Copyright dates and version numbers updated where needed. > 3. Source file updated. > 4. One CC line in Makefile.sfw removed as this causes a failed build due to a > known bug in the configure file for 1.6.4. > 5. fi language files removed in prototype_com since these do not exist in 1.6.4. > 6. Various file locations fixed in install-sfw. > > The package builds cleanly and produces a working SFWenscr package. 1. src/cmd/enscript/METADATA Change lower case characters ... bugtRAQ: ---> BUGTRAQ: -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit From Alan.Coopersmith at Sun.COM Tue Jan 6 08:09:15 2009 From: Alan.Coopersmith at Sun.COM (Alan Coopersmith) Date: Tue, 06 Jan 2009 08:09:15 -0800 Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 238 In-Reply-To: <989421257.481231238656367.JavaMail.Twebapp@sf-app1> References: <989421257.481231238656367.JavaMail.Twebapp@sf-app1> Message-ID: <4963822B.8040001@sun.com> Steve Christensen wrote: > This is a code review request for the update of the SFWxterm package to version 238. The webrev is at This is for the S10 companion only, right? That version of xterm is delivered in the X consolidation in Nevada & OpenSolaris already. -- -Alan Coopersmith- alan.coopersmith at sun.com Sun Microsystems, Inc. - X Window System Engineering From sunfreeware at gmail.com Tue Jan 6 11:29:14 2009 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Tue, 06 Jan 2009 14:29:14 -0500 Subject: [companion-discuss] Code Review Request: Update of SFWxterm to version 238 In-Reply-To: <4963822B.8040001@sun.com> References: <989421257.481231238656367.JavaMail.Twebapp@sf-app1> <4963822B.8040001@sun.com> Message-ID: <4963B10A.30906@gmail.com> Correct Alan - if I update anything that is already in Nevada etc, then it is done for Solaris 10 only. Cheers, Steve C. Alan Coopersmith wrote: > Steve Christensen wrote: >> This is a code review request for the update of the SFWxterm package to version 238. The webrev is at > > This is for the S10 companion only, right? That version of xterm > is delivered in the X consolidation in Nevada & OpenSolaris already. > From sunfreeware at gmail.com Tue Jan 13 03:06:33 2009 From: sunfreeware at gmail.com (Steve Christensen) Date: Tue, 13 Jan 2009 03:06:33 PST Subject: [companion-discuss] Code Review Request: Update of SFWslrn Package Message-ID: <886192290.261231844823584.JavaMail.Twebapp@sf-app1> This is a code review request for the update of the SFWslrn package to version 0.9.9p1. The webrev is at http://companion.sunfreeware.com/downloads/slrnwebrev/ Details: 1. Updated source file. 2. Changed version numbers and copyright dates were needed. 3. Updated METADATA file. 4. Modified install-sfw and prototype_com to add two files slrn.sl and INSTFILES to share/slrn. The code builds cleanly and produces a working SFWslrn package. Steve Christensen -- This message posted from opensolaris.org From paul.cunningham at tadpole.com Tue Jan 13 05:12:17 2009 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Tue, 13 Jan 2009 13:12:17 +0000 Subject: [companion-discuss] Code Review Request: Update of SFWslrn Package In-Reply-To: <886192290.261231844823584.JavaMail.Twebapp@sf-app1> References: <886192290.261231844823584.JavaMail.Twebapp@sf-app1> Message-ID: <496C9331.20804@tadpole.com> This looks okay to me Paul Steve Christensen wrote: > This is a code review request for the update of the SFWslrn package to version 0.9.9p1. The webrev is at > > http://companion.sunfreeware.com/downloads/slrnwebrev/ > > Details: > > 1. Updated source file. > 2. Changed version numbers and copyright dates were needed. > 3. Updated METADATA file. > 4. Modified install-sfw and prototype_com to add two files slrn.sl and INSTFILES to share/slrn. > > The code builds cleanly and produces a working SFWslrn package. > > Steve Christensen -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit From sunfreeware at gmail.com Mon Jan 19 00:55:43 2009 From: sunfreeware at gmail.com (Steve Christensen) Date: Mon, 19 Jan 2009 00:55:43 PST Subject: [companion-discuss] Code Review Request: Update of SFWxmcd Package Message-ID: <913151331.14501232355374036.JavaMail.Twebapp@sf-app1> This is a code review request for the update of the SFWxmcd to version 3.3.2. The webrev is at http://companion.sunfreeware.com/downloads/xmcdwebrev Details: 1. Updated source code file. 2. Updated version numbers and copyright where needed. 3. Added METADATA file. 4. Removed SCCS ids. 4. Removed a number of help files that no longer exist in install-sfw and prototype_com. 5. Modified make.inc to match Solaris install locations and dependencies. This builds cleanly and produces a working SFWxmcd package. Steve Christensen -- This message posted from opensolaris.org From paul.cunningham at tadpole.com Mon Jan 19 01:46:17 2009 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Mon, 19 Jan 2009 09:46:17 +0000 Subject: [companion-discuss] Code Review Request: Update of SFWxmcd Package In-Reply-To: <913151331.14501232355374036.JavaMail.Twebapp@sf-app1> References: <913151331.14501232355374036.JavaMail.Twebapp@sf-app1> Message-ID: <49744BE9.5030107@tadpole.com> this looks good to me paul Steve Christensen wrote: > This is a code review request for the update of the SFWxmcd to version 3.3.2. The webrev is at > > http://companion.sunfreeware.com/downloads/xmcdwebrev > > Details: > > 1. Updated source code file. > 2. Updated version numbers and copyright where needed. > 3. Added METADATA file. > 4. Removed SCCS ids. > 4. Removed a number of help files that no longer exist in install-sfw and prototype_com. > 5. Modified make.inc to match Solaris install locations and dependencies. > > This builds cleanly and produces a working SFWxmcd package. > > Steve Christensen -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit From sunfreeware at gmail.com Fri Jan 30 02:12:32 2009 From: sunfreeware at gmail.com (Steve Christensen) Date: Fri, 30 Jan 2009 02:12:32 PST Subject: [companion-discuss] Code Review Request: Minor bug fix in SFWgviz (graphviz) Package Message-ID: <1254880627.251233310382436.JavaMail.Twebapp@sf-app1> This is a code review request for a bug fix in the graphviz package SFWgviz. There is an outstanding bug (CR# 5028235) filed against this package. The agraph.3 man page has a line that causes catman to fail in /opt/sfw/man/man3 for this file. Removing one line fixes this and still gives a working man page. The webrev is at http://companion.sunfreeware.com/downloads/graphvizwebrev/ Details: 1. A patch is created to fix the agraph.3 file. 2. A patch line is added in Makefile.sfw. 3. A METADATA file is added. 4. Copyright dates fixed where needed. The package builds and installs correctly. Steve Christensen -- This message posted from opensolaris.org From paul.cunningham at tadpole.com Fri Jan 30 06:06:46 2009 From: paul.cunningham at tadpole.com (Paul Cunningham) Date: Fri, 30 Jan 2009 14:06:46 +0000 Subject: [companion-discuss] Code Review Request: Minor bug fix in SFWgviz (graphviz) Package In-Reply-To: <1254880627.251233310382436.JavaMail.Twebapp@sf-app1> References: <1254880627.251233310382436.JavaMail.Twebapp@sf-app1> Message-ID: <49830976.6000101@tadpole.com> This looks okay to me Paul Steve Christensen wrote: > This is a code review request for a bug fix in the graphviz package SFWgviz. > There is an outstanding bug (CR# 5028235) filed against this package. The > agraph.3 man page has a line that causes catman to fail in /opt/sfw/man/man3 for > this file. Removing one line fixes this and still gives a working man page. > > The webrev is at > > http://companion.sunfreeware.com/downloads/graphvizwebrev/ > > Details: > > 1. A patch is created to fix the agraph.3 file. > 2. A patch line is added in Makefile.sfw. > 3. A METADATA file is added. > 4. Copyright dates fixed where needed. > > The package builds and installs correctly. > > Steve Christensen -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit