From sunfreeware at gmail.com  Tue May 12 17:00:20 2009
From: sunfreeware at gmail.com (Steve Christensen)
Date: Tue, 12 May 2009 17:00:20 PDT
Subject: [companion-discuss] Code Review Request: Update of SFWsudo Package
Message-ID: <248524841.51721242172850528.JavaMail.Twebapp@sf-app1>

This is code review request for the update of the SFWsudo package to version 1.7.1.

The webrev is at

http://companion.sunfreeware.com/downloads/sudowebrev/

Details:

1.  Update of source code file.
2.  Update of Copyright year.
3.  Changed version number where needed.

The package builds and installs properly producing a working sudo.

Steve Christensen
-- 
This message posted from opensolaris.org


From paul.cunningham at tadpole.com  Wed May 13 00:52:49 2009
From: paul.cunningham at tadpole.com (Paul Cunningham)
Date: Wed, 13 May 2009 08:52:49 +0100
Subject: [companion-discuss] Code Review Request: Update of SFWsudo
	Package
In-Reply-To: <248524841.51721242172850528.JavaMail.Twebapp@sf-app1>
References: <248524841.51721242172850528.JavaMail.Twebapp@sf-app1>
Message-ID: <4A0A7C51.6000206@tadpole.com>

Steve,

Mainly looks good to me. See couple of comments below ...

Paul

Steve Christensen wrote:
> This is code review request for the update of the SFWsudo package to version 1.7.1.
> 
> The webrev is at
> http://companion.sunfreeware.com/downloads/sudowebrev/
> 
> Details:
> 1.  Update of source code file.
> 2.  Update of Copyright year.
> 3.  Changed version number where needed.
> 
> The package builds and installs properly producing a working sudo.

1. src/cmd/sudo/METADATA
    Just as a note; you may have noticed that SFWNV has changed
    the format of this so you might want to change also at some point
    "http://wikis.sun.com/display/SFWNotes/METADATA"

2. src/cmd/sudo/README.SFWsudo
    It doesn't look as though you have changed this


-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit


From sunfreeware at gmail.com  Thu May 14 01:26:45 2009
From: sunfreeware at gmail.com (Steve Christensen)
Date: Thu, 14 May 2009 01:26:45 PDT
Subject: [companion-discuss] Code Review Request: update of SFWftchm
	(fetchmail) Package
Message-ID: <1468578845.54761242289635381.JavaMail.Twebapp@sf-app1>

This is a code review request for the update of the SFWftchm (fetchmail) package to version 6.3.9.

The webrev is at

http://companion.sunfreeware.com/downloads/fetchmailwebrev/

This is a security issue and critical bug fix release according to the fetchmail site.

Details:

The only changes are to the version number, source file, and copyright date.
A working fetchmail package results from the standard build.

Steve Christensen
-- 
This message posted from opensolaris.org


From paul.cunningham at tadpole.com  Thu May 14 01:36:43 2009
From: paul.cunningham at tadpole.com (Paul Cunningham)
Date: Thu, 14 May 2009 09:36:43 +0100
Subject: [companion-discuss] Code Review Request: update of
 SFWftchm	(fetchmail) Package
In-Reply-To: <1468578845.54761242289635381.JavaMail.Twebapp@sf-app1>
References: <1468578845.54761242289635381.JavaMail.Twebapp@sf-app1>
Message-ID: <4A0BD81B.9040509@tadpole.com>

Steve,

This looks okay to me from my quick skip through

Paul

Steve Christensen wrote:
> This is a code review request for the update of the SFWftchm (fetchmail) package to version 6.3.9.
> 
> The webrev is at
> http://companion.sunfreeware.com/downloads/fetchmailwebrev/
> 
> This is a security issue and critical bug fix release according to the fetchmail site.
> 
> Details:
> The only changes are to the version number, source file, and copyright date.
> A working fetchmail package results from the standard build.

-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit