[companion-integrate] RTI - pkgefs repairs

Marilyn Shoemaker marilyn.shoemaker at sun.com
Tue Oct 17 10:13:27 PDT 2006


approved

marilyn

Steven M. Christensen wrote:
> I would like to submit a RTI for fixes to the pkgdef files
> in the Companion CD project.
> 
> The code reviewers for this upgrade have been Paul Cunningham
> and Mike Sullivan (details in companion-discuss).  Suggested
> fixes have been made and no further comments received.
> 
> These changes build cleanly on SPARC and x86 for Nevada build 45
> in nightly builds. 
> 
> Details of the changes are
> 
> 1.  Some of the SFW directories in pkgdefs contained depend files as
> part of the svn repository that are actually supposed to be generated
> by the Makefile when the depend file is just the generic file and has
> no extra dependencies added to it.  Some of these depends were probably
> put there during the SCCS to svn transition incorrectly and others added
> just in error.
> 
> I have removed the unneeded depend files and made sure the Makefile in
> each SFW directory contains the DATAFILES += depend line when required.
> There are also some cases where i.preserve files were not needed and
> those have been removed and where required generated by the Makefile.
> 
> 2.  Some of the DATAFILES += depend lines in the Makefiles were incorrect,
> leaving out the + and those have been corrected.
> 
> 3.  There were inconsistencies in some of the prototype_com files.
> Some had man and info pages and directories owned by bin bin and others
> by root bin.  Since the man pages in /usr/man are root bin, I changed
> those prototype_com files so that ownerships are all root bin as well.
> This avoids some warning messages during pkgadd's of the packages.
> 
> The webrev for this is at
> 
> http://companion.sunfreeware.com/downloads/dependwebrev/
> 
> Steve Christensen
> _______________________________________________
> companion-integrate mailing list
> companion-integrate at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-integrate



More information about the companion-integrate mailing list