[companion-integrate] RTI - Update of SFWlpcap (libpcap) and SFWtdmp (tcpdump)

[Mike Sullivan]

Steve Christensen wrote:
> This is a RTI for the update of SFWlcap (libpcap) to version 0.9.6 and
> SFWtdmp (tcpdump) to version 3.9.6.  Since these two items are closely 
> connected, they are submitted as one review.
> 

3.9.7 is out. Though I wouldn't stop you from doing 3.9.6, it might
be worth seeing if it would be quick to do. libpcap also is 0.9.7 now.

> 5.  Patches -
> 
>       libpcap's source code has two files where the version numbers are
>       not updated.  This is a known bug that has already been submitted
>       to the libpcap/tcpdump mailing lists.  This patch fixes this issue.
> 
>       The tcpdump patch also updates one version number and modifies the
>       ether.h file so that if ETHERMTU exists in the system (which it
>       does in Solaris in /usr/include/sys/ethernet.h), the
>       definitions in the ether.h file are ignored. This is the now
>       standard fix for this problem.

I'm not sure why we need to patch the version numbers but I suppose.
it looks like the .9.7 versions have fixed those though, perhaps that's
a good reason to move to them. Though the ether.h problem still exists.
When you say 'now standard fix' do you mean they know and are going
to fix it?

I love seeing this during tcpdump's configure run:

checking whether to enable the possibly-buggy SMB printer... yes
configure: WARNING: The SMB printer may have exploitable buffer overflows!!!

Anyway, approved, though I'd still suggest going to .9.7.

	Mike