[companion-integrate] RTI - Update of SFWamnda (amanda) Package
Mike Sullivan
Mike.Sullivan at Sun.COM
Mon Jun 25 12:18:08 PDT 2007
Steve Christensen wrote:
> This is a RTI for the update of the SFWamnda (amanda) package to version
> 2.5.2p1.
>
> The webrev is at
>
> http://companion.sunfreeware.com/downloads/amandawebrev/
>
> The code reviewer has been Paul Cunningham (see companion-discuss).
>
> The changes were:
>
> 1. Update of source version numbers and source file.
> 2. Update of copyrights and removal of sccs ids.
> 3. Addition of METADATA file.
The license in the METADATA file claims GPL2 but the web page claims
BSD. Though it looks like BSD modified for UM. You really need to
check each license when you create the METADATA file, having it there
but wrong does no good.
> 4. Changes of library version numbers in install-sfw and prototype_com
> files.
strange that the install-sfw script wants to use /bin/sh -e, but it
appears the CDDL was added in comments above that line and disabled
that.
you should probably go make sure the CDDL insertion went after any
such lines. well and fix them.
Mike
More information about the companion-integrate
mailing list