[companion-integrate] RTI - Removal of Source Packages

Tue May 22 03:42:12 PDT 2007

Mike -

I have redone the README files along the lines you suggest.  Deleting 
most of them and modifying others.  I edited the Makefile.sfw files to 
deal with the README files and removed those .WAIT entries that were not 
needed.

The webrev is at

http://companion.sunfreeware.com/downloads/nosourcewebrev/

This builds as non-root user on NV62 with no problems.  I am now doing a 
root nightly build to check on the chmod issues you suggest might appear 
there.  I will report this result this afternoon.

I also edited all the METADATA files to remove the reference to the 
source packages.

Steve C.

Mike Sullivan wrote:
> Steve Christensen wrote:
>> This is an RTI for the removal of the building of source packages on 
>> the Companion CD.
>>
>> This code has been reviewed by Norm Jacobs, Mike Sullivan, and Paul 
>> Cunningham.
>>
>> The webrev is at
>>
>> http://companion.sunfreeware.com/downloads/nosourcewebrev/
> 
> I don't see any README.sfw's being deleted. They should, as
> they only go in the source package and explain how we compiled
> it. These are distinct of course from any README-type things
> the packages install to help you actually use the installed
> bits, don't delete those (they often seem to be referenced as
> ROOTREADME, but perhaps not all do that :) And if somebody decided to
> put more info into a README.sfw than just the how-to-compile bits,
> like say comments on porting or issues to watch our for when
> upgrading the software, then that could certainly stay - though
> I'd rename it to just a README.
> 
> cmd/screen/Makefile.sfw
> cmd/emacs/Makefile.sfw
> cmd/emacspeak/Makefile.sfw
> cmd/ocaml/Makefile.sfw
> cmd/global/Makefile.sfw
> cmd/cups/Makefile.sfw
> cmd/joe/Makefile.sfw
> cmd/file/Makefile.sfw
> cmd/xmms/Makefile.sfw
> cmd/tetex/Makefile.sfw
> cmd/ddd/Makefile.sfw
> cmd/mpack/Makefile.sfw
> cmd/uudeview/Makefile.sfw
> cmd/xterm/Makefile.sfw
> cmd/xpdf/Makefile.sfw
> cmd/ctags/Makefile.sfw
> cmd/openldap/Makefile.sfw
> cmd/libtool/Makefile.sfw
> cmd/unison/Makefile.sfw
> cmd/tcpdump/Makefile.sfw
> cmd/pnm2ppa/Makefile.sfw
> cmd/lablgtk/Makefile.sfw
> cmd/openslp/Makefile.sfw
> cmd/php/Makefile.sfw
> cmd/expect/Makefile.sfw
> cmd/ethereal/Makefile.sfw
> cmd/graphviz/Makefile.sfw
> cmd/xmcd/Makefile.sfw
> cmd/cvs/Makefile.sfw
> cmd/nmap/Makefile.sfw
> cmd/tnef/Makefile.sfw
> cmd/rpm/Makefile.sfw
> cmd/rsync/Makefile.sfw
> cmd/xpp/Makefile.sfw
> cmd/screenbrltty/Makefile.sfw
> cmd/amanda/Makefile.sfw
> cmd/xdelta/Makefile.sfw
> cmd/squid/Makefile.sfw
> cmd/cupsprint/Makefile.sfw
> cmd/ispell/Makefile.sfw
> cmd/gnuplot/Makefile.sfw
> cmd/mutt/Makefile.sfw
> cmd/vim/Makefile.sfw
> cmd/cupsddk/Makefile.sfw
> cmd/findutils/Makefile.sfw
> cmd/automake/Makefile.sfw
> cmd/proftpd/Makefile.sfw
> lib/berkeley-db/Makefile.sfw
> lib/pcre/Makefile.sfw
> lib/gd/Makefile.sfw
> lib/imlib/Makefile.sfw
> lib/fltk/Makefile.sfw
> lib/guile/Makefile.sfw
> lib/libpcap/Makefile.sfw
> 
>     a couple of finds were deleted that run after the tar
>     file is extracted, and they look like they might be
>     fixing up permissions on the extracted source and not the
>     source that gets copied into the proto area for the source
>     packages. Are you sure that they should be
>     deleted (does the tar file extract correctly?) It almost
>     looks like these were fixing permissions that are busted
>     when root extracts the tar file, though if so it's probably
>     better to just add 'o' to the tar options. Well that's for
>     normal tar for gtar you need to add --no-same-owner at the end.
> 
>     And yes if that's the case, then it might only affect
>     root builds - but the point of the non-root work was not
>     to just make non-root work, but to make builds as _anyone_
>     work. plus I still build as root so please don't break me :)
>     Well, it probably doesn't really break root builds, but it
>     can make it tough to change things in such a root-built
>     workspace as a normal user. But it depends on the contents
>     of the tar file and it might only matter to teamware (not sure).
> 
>     It's also hard to tell if these are needed as many places
>     as they are or if it's just a few that have been copied
>     and copied.
> 
>     The safe thing might be to just leave the finds in place.
> 
> cmd/mysql-connector-java/Makefile.sfw
> 
>     is similar but it's a chmod -R which makes things writable.
>     weird so maybe it's not needed either. But it also has
>     the finds even though they're part of install_src - maybe
>     those should be moved to after the extraction.
> 
> cmd/fvwm/Makefile.sfw
> 
>     another chmod -R a+w. Which can't be right but I do wonder.
> 
> cmd/xemacs/Makefile.sfw
> cmd/ruby/Makefile.sfw
> cmd/vnc/java/Makefile.sfw
> cmd/emacs/Makefile.sfw
> cmd/w3/Makefile.sfw
> cmd/ocaml/Makefile.sfw
> cmd/global/Makefile.sfw
> cmd/gcal/Makefile.sfw
> cmd/sed/Makefile.sfw
> cmd/sharutils/Makefile.sfw
> cmd/joe/Makefile.sfw
> cmd/slrn/Makefile.sfw
> cmd/file/Makefile.sfw
> cmd/gettext/Makefile.sfw
> cmd/diffutils/Makefile.sfw
> cmd/ddd/Makefile.sfw
> cmd/pine/Makefile.sfw
> cmd/fetchmail/Makefile.sfw
> cmd/uudeview/Makefile.sfw
> cmd/xterm/Makefile.sfw
> cmd/xpdf/Makefile.sfw
> cmd/ctags/Makefile.sfw
> cmd/top/Makefile.sfw
> cmd/tcpdump/Makefile.sfw
> cmd/pnm2ppa/Makefile.sfw
> cmd/lablgtk/Makefile.sfw
> cmd/expect/Makefile.sfw
> cmd/lynx/Makefile.sfw
> cmd/cvs/Makefile.sfw
> cmd/nmap/Makefile.sfw
> cmd/tnef/Makefile.sfw
> cmd/vorbis-tools/Makefile.sfw
> cmd/rxvt/Makefile.sfw
> cmd/groff/Makefile.sfw
> cmd/coreutils/Makefile.sfw
> cmd/sgrep/Makefile.sfw
> cmd/xdelta/Makefile.sfw
> cmd/nmh/Makefile.sfw
> cmd/squid/Makefile.sfw
> cmd/gawk/Makefile.sfw
> cmd/cupsddk/Makefile.sfw
> cmd/plotutils/Makefile.sfw
> cmd/findutils/Makefile.sfw
> cmd/procmail/Makefile.sfw
> cmd/automake/Makefile.sfw
> lib/ncurses/Makefile.sfw
> lib/SDL/Makefile.sfw
> lib/readline/Makefile.sfw
> lib/berkeley-db/Makefile.sfw
> lib/xaw3d/Makefile.sfw
> lib/libao/Makefile.sfw
> lib/fnlib/Makefile.sfw
> lib/gd/Makefile.sfw
> lib/imlib/Makefile.sfw
> lib/libungif/Makefile.sfw
> lib/berkeley-db_1.85/Makefile.sfw
> lib/slang/Makefile.sfw
> lib/guile/Makefile.sfw
> lib/curl/Makefile.sfw
> lib/aalib/Makefile.sfw
> lib/libpcap/Makefile.sfw
> lib/tclx/Makefile.sfw
> 
>     there's a .WAIT at the end of the install target line.
>     it's useless, delete it.
> 
>     Mike
> 
>> Details:
>>
>> 1. Removal of the DISTDIRS.sfw, DISTFILES.sfw, and EXFILES.sfw files 
>> from all directories.
>> 2. The removal of the SFW...S directories in pkgdefs.
>> 3. The editing of the Makefile in pkgdefs to remove the makes of the 
>> source directories there.
>> 4. The editing of all Makefile.sfw files to remove anything to do with 
>> source package generation.
>> 5. The removal of other files no longer needed like makedist and 
>> fixsrc in the tools directory.
>> 6. Updating of Copyrights where needed.
>>
>>
>> A nightly build of the new code is completely clean with no protocmp 
>> errors on NV 62.  No source packages were generated and the only 
>> things now in /opt/sfw/src are from the rpm build that needs to place 
>> a few files there.
>>
>> Steve Christensen
>> _______________________________________________
>> companion-integrate mailing list
>> companion-integrate at opensolaris.org
>> http://opensolaris.org/mailman/listinfo/companion-integrate
>>
> 
> 