From sunfreeware at gmail.com Mon Feb 18 01:05:43 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Mon, 18 Feb 2008 04:05:43 -0500 Subject: [companion-integrate] RTI - Minor fix to pkgdefs/Makefile Message-ID: <47B94A67.3080103@gmail.com> This is a RTI for a fix to the pkgdefs/Makefile. An extra \ somehow found its way into the pkgdefs/Makefile file. This has been removed. See http://companion.sunfreeware.com/downloads/makefilewebrev/ This change and been reviewed and approved by Paul Cunningham. This makes no difference to nightly builds. Steve Christensen From sunfreeware at gmail.com Mon Feb 18 18:22:03 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Mon, 18 Feb 2008 21:22:03 -0500 Subject: [companion-integrate] RTI - Update of SFWafio Package Message-ID: <47BA3D4B.4080705@gmail.com> This is a RTI for the update of the afio Companion CD package to version 2.5 and a complete redo on its build structure to match the Companion standard. The webrev is at http://companion.sunfreeware.com/downloads/afiowebrev/ This has been reviewed and approved by Paul Cunningham. The details are: 1. All afio source files have been removed. 2. The afio 2.5 source file has been added. 3. A METADATA has been added. 4. The Makefile.sfw file has been modified to fit the normal build method. 5. A patch to the CFLAGS in the Makefile has been added. 6. An install-sfw file has been added. 7. The pkgdefs/SFWafio/pkginfo.tmpl file has been updated. 8. Copyright and version numbers updated where needed. SCCS ids removed. A nightly build is clean on NV 81. Steve Christensen From Mike.Sullivan at sun.com Tue Feb 19 11:45:41 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 19 Feb 2008 11:45:41 -0800 Subject: [companion-integrate] RTI - Minor fix to pkgdefs/Makefile In-Reply-To: <47B94A67.3080103@gmail.com> References: <47B94A67.3080103@gmail.com> Message-ID: <47BB31E5.9020709@Sun.COM> Steven M. Christensen wrote: > This is a RTI for a fix to the pkgdefs/Makefile. An extra \ somehow > found its way into the pkgdefs/Makefile file. This has been removed. go for it. From Mike.Sullivan at sun.com Tue Feb 19 11:57:08 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 19 Feb 2008 11:57:08 -0800 Subject: [companion-integrate] RTI - Update of SFWafio Package In-Reply-To: <47BA3D4B.4080705@gmail.com> References: <47BA3D4B.4080705@gmail.com> Message-ID: <47BB3494.2010606@Sun.COM> Steven M. Christensen wrote: > This is a RTI for the update of the afio Companion CD package to version > 2.5 and a complete redo on its build structure to match the Companion > standard. > 2. The afio 2.5 source file has been added. > 3. A METADATA has been added. Is freshmeat.net really the best thing to put in the URL spot? I thought of that site more of a directory not the true location. And since the tar file seems to be on ibiblio or in somebody's home directory it would seem like there must be a better place. Hmm though the README does point out freshmeat - so maybe it's fine. Actually it looks like it's licensed under the LGPL and the perl Artistic license, plus at least 2 more. > 4. The Makefile.sfw file has been modified to fit the normal build > method. You really shouldn't have to add -L/usr/lib or -R/usr/lib I'd think, unless you're trying to force a search order (perhaps you are though). Since some CFLAGS are no longer forced, does it properly pick the right ones? notably fdformat/gzip? Ah I see fdformat in the patch but please make sure it still builds the same way (I'm assuming the old way worked :) BTW you can probably not add the .SUFFIXES anymore - I just removed that for sfw because it was only for building the source packages, which we (and you) don't do anymore. > 5. A patch to the CFLAGS in the Makefile has been added. > 6. An install-sfw file has been added. Shouldn't you use the install.subr functions there instead? Mike From sunfreeware at gmail.com Tue Feb 19 22:35:26 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Wed, 20 Feb 2008 01:35:26 -0500 Subject: [companion-integrate] RTI - Update of SFWafio Package In-Reply-To: <47BB3494.2010606@Sun.COM> References: <47BA3D4B.4080705@gmail.com> <47BB3494.2010606@Sun.COM> Message-ID: <47BBCA2E.9040201@gmail.com> Mike - The webrev http://companion.sunfreeware.com/downloads/afiowebrev/ has been updated with your suggested changes. See my comments below. Steve C. Mike Sullivan wrote: > Steven M. Christensen wrote: >> This is a RTI for the update of the afio Companion CD package to >> version 2.5 and a complete redo on its build structure to match the >> Companion standard. > >> 2. The afio 2.5 source file has been added. >> 3. A METADATA has been added. > > Is freshmeat.net really the best thing to put in the > URL spot? I thought of that site more of a directory > not the true location. And since the tar file seems to be > on ibiblio or in somebody's home directory it would seem > like there must be a better place. Hmm though the README > does point out freshmeat - so maybe it's fine. > > Actually it looks like it's licensed under the LGPL and > the perl Artistic license, plus at least 2 more. I have changed the URL to http://aa-project.sourceforge.net/aalib/ which is better than the freshmeat location. I also added the Perl Artistic license and one other to the METADATA file to match the information in afio.c. > >> 4. The Makefile.sfw file has been modified to fit the normal build >> method. > > You really shouldn't have to add -L/usr/lib or -R/usr/lib I'd think, > unless you're trying to force a search order (perhaps you are though). The /usr/lib flags are not needed and I removed them. > > Since some CFLAGS are no longer forced, does it properly pick the > right ones? notably fdformat/gzip? Ah I see fdformat in the patch > but please make sure it still builds the same way (I'm assuming > the old way worked :) The CFLAGS in the build - using the patch - are correct and match the older CFLAGS. fdformat and gzip are in the flags correctly. > > BTW you can probably not add the .SUFFIXES anymore - I just removed > that for sfw because it was only for building the source packages, > which we (and you) don't do anymore. .SUFFIXES line removed. > >> 5. A patch to the CFLAGS in the Makefile has been added. >> 6. An install-sfw file has been added. > > Shouldn't you use the install.subr functions there instead? Did this also. > > Mike > > From Mike.Sullivan at sun.com Tue Feb 19 23:09:09 2008 From: Mike.Sullivan at sun.com (Mike.Sullivan at sun.com) Date: Tue, 19 Feb 2008 23:09:09 -0800 (PST) Subject: [companion-integrate] RTI - Update of SFWafio Package Message-ID: <200802200709.m1K799vn899714@yavin.Eng.Sun.COM> >From companion-integrate-bounces at opensolaris.org Tue Feb 19 22:36:54 2008 >The webrev > >http://companion.sunfreeware.com/downloads/afiowebrev/ > >has been updated with your suggested changes. >> Is freshmeat.net really the best thing to put in the >> URL spot? I thought of that site more of a directory >> not the true location. And since the tar file seems to be >> on ibiblio or in somebody's home directory it would seem >> like there must be a better place. Hmm though the README >> does point out freshmeat - so maybe it's fine. >> >> Actually it looks like it's licensed under the LGPL and >> the perl Artistic license, plus at least 2 more. > >I have changed the URL to > >http://aa-project.sourceforge.net/aalib/ > >which is better than the freshmeat location. I thought aalib was different than afio? I don't know enough about either but they seem to be. As I said above I'm ok with the freshmeat address given the source (README I think) points there it just felt wrong. >I also added the Perl Artistic license and one other to >the METADATA file to match the information in afio.c. Ok. I saw at least four in one file but I don't remember which file I looked at (probably a header but I could have just done 'more *.c'). Approved pending resolution of the URL bit (restoration of the freshmeat address, or confirmation this new one is correct). Mike From sunfreeware at gmail.com Tue Feb 19 23:34:57 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Wed, 20 Feb 2008 02:34:57 -0500 Subject: [companion-integrate] RTI - Update of SFWafio Package In-Reply-To: <200802200709.m1K799vn899714@yavin.Eng.Sun.COM> References: <200802200709.m1K799vn899714@yavin.Eng.Sun.COM> Message-ID: <47BBD821.4030608@gmail.com> The URL is just a dumb error on my part. Working on too many updates that start with a. I have fixed the afio URL in the METADATA and pkginfo.tmpl back to the freshmeat one which is the only valid one I can find. The afio.c file is the only file that has license info in it and I think I have covered the ones mentioned there. The webrev have been updated. Steve C. Mike.Sullivan at sun.com wrote: >>From companion-integrate-bounces at opensolaris.org Tue Feb 19 22:36:54 2008 > >> The webrev >> >> http://companion.sunfreeware.com/downloads/afiowebrev/ >> >> has been updated with your suggested changes. > >>> Is freshmeat.net really the best thing to put in the >>> URL spot? I thought of that site more of a directory >>> not the true location. And since the tar file seems to be >>> on ibiblio or in somebody's home directory it would seem >>> like there must be a better place. Hmm though the README >>> does point out freshmeat - so maybe it's fine. >>> >>> Actually it looks like it's licensed under the LGPL and >>> the perl Artistic license, plus at least 2 more. >> I have changed the URL to >> >> http://aa-project.sourceforge.net/aalib/ >> >> which is better than the freshmeat location. > > I thought aalib was different than afio? > I don't know enough about either but they seem to be. > As I said above I'm ok with the freshmeat address given > the source (README I think) points there it just felt > wrong. > >> I also added the Perl Artistic license and one other to >> the METADATA file to match the information in afio.c. > > Ok. I saw at least four in one file but I don't remember which > file I looked at (probably a header but I could have just done > 'more *.c'). > > Approved pending resolution of the URL bit (restoration > of the freshmeat address, or confirmation this new one is > correct). > > Mike > From sunfreeware at gmail.com Fri Feb 22 01:22:10 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Fri, 22 Feb 2008 04:22:10 -0500 Subject: [companion-integrate] RTI - Update of SFWsudo Package Message-ID: <47BE9442.1000309@gmail.com> This is a RTI for the update of SFWsudo from version 1.6.9p4 to version 1.6.9p13. The webrev is at http://companion.sunfreeware.com/downloads/sudowebrev/ This has been reviewed and approved by Paul Cunningham. Changes were simple - 1. Update of sudo source code file. 2. Copyrights and version numbers changed where needed. Nightly build on NV 81 is clean. A test pkgadd works and creates a working sudo program. Steve Christensen From sunfreeware at gmail.com Sun Feb 24 15:08:03 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Sun, 24 Feb 2008 18:08:03 -0500 Subject: [companion-integrate] RTI - Update of SFWsnort Package Message-ID: <47C1F8D3.1050800@gmail.com> This is a RTI for the update of the SFWsnort package to version 2.8.0.2. The webrev is at http://companion.sunfreeware.com/downloads/snortwebrev/ Code reviewed and approved by Paul Cunningham. Details - This is a very simple update. The source code file is replaced with the latest one, version numbers are updated and copyrights changed where needed. The source code file is now .gz instead of .bz2 because the snort website uses .gz and does not offer .bz2. A nightly build on NV81 works with no errors and a pkgadd install creates a working snort system. Steve Christensen From sunfreeware at gmail.com Mon Feb 25 01:28:41 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Mon, 25 Feb 2008 04:28:41 -0500 Subject: [companion-integrate] RTI - Update of SFWsquid Package Message-ID: <47C28A49.4030201@gmail.com> This is a RTI for the update of the Companion SFWsquid package from version 2.5.STABLE7 to version 2.6.STABLE18. The webrev is at http://companion.sunfreeware.com/downloads/squidwebrev/ This has been reviewed and approved by Paul Cunningham. Details - 1. Source file updated. .gz compression used since that is what the Squid site offers. 2. METADATA file added 3. Version numbers updated where needed (called 2.6.18 in pkginfo.tmpl) 4. Copyright dates changed and SCCS ids removed when required 5. .SUFFIXES line removed in Makefile.sfw - no longer needed 6. RunAccel removed in install-sfw and prototype_com - not part of 2.6.x anymore 7. cachemgr.conf added in install-sfw and protoytpe_com - new in 2.6.x 8. location of squidclient and cachemgr.cgi files fixed in install-sfw A nightly build on NV 81 works and a test pkgadd appears to create a working squid system. Steve Christensen From sunfreeware at gmail.com Mon Feb 25 01:28:41 2008 From: sunfreeware at gmail.com (Steven M. Christensen) Date: Mon, 25 Feb 2008 04:28:41 -0500 Subject: [companion-integrate] RTI - Update of SFWsquid Package Message-ID: <47C28A49.4030201@gmail.com> This is a RTI for the update of the Companion SFWsquid package from version 2.5.STABLE7 to version 2.6.STABLE18. The webrev is at http://companion.sunfreeware.com/downloads/squidwebrev/ This has been reviewed and approved by Paul Cunningham. Details - 1. Source file updated. .gz compression used since that is what the Squid site offers. 2. METADATA file added 3. Version numbers updated where needed (called 2.6.18 in pkginfo.tmpl) 4. Copyright dates changed and SCCS ids removed when required 5. .SUFFIXES line removed in Makefile.sfw - no longer needed 6. RunAccel removed in install-sfw and prototype_com - not part of 2.6.x anymore 7. cachemgr.conf added in install-sfw and protoytpe_com - new in 2.6.x 8. location of squidclient and cachemgr.cgi files fixed in install-sfw A nightly build on NV 81 works and a test pkgadd appears to create a working squid system. Steve Christensen From Mike.Sullivan at sun.com Mon Feb 25 11:24:54 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Mon, 25 Feb 2008 11:24:54 -0800 Subject: [companion-integrate] RTI - Update of SFWsquid Package In-Reply-To: <47C28A49.4030201@gmail.com> References: <47C28A49.4030201@gmail.com> Message-ID: <47C31606.8010907@Sun.COM> Steven M. Christensen wrote: > This is a RTI for the update of the Companion SFWsquid package from > version 2.5.STABLE7 to version 2.6.STABLE18. The webrev is at > > http://companion.sunfreeware.com/downloads/squidwebrev/ > > This has been reviewed and approved by Paul Cunningham. > > Details - > > 1. Source file updated. .gz compression used since that is what the > Squid site offers. > 2. METADATA file added > 3. Version numbers updated where needed (called 2.6.18 in pkginfo.tmpl) > 4. Copyright dates changed and SCCS ids removed when required > 5. .SUFFIXES line removed in Makefile.sfw - no longer needed > 6. RunAccel removed in install-sfw and prototype_com - not part of > 2.6.x anymore > 7. cachemgr.conf added in install-sfw and protoytpe_com - new in 2.6.x > 8. location of squidclient and cachemgr.cgi files fixed in install-sfw > > A nightly build on NV 81 works and a test pkgadd appears to create a > working squid system. squid 2.6 has been bundled in nevada since build 77, and I think actually working since 78 :) why do we need to update the one on the ccd? Mike From Mike.Sullivan at sun.com Mon Feb 25 12:03:19 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Mon, 25 Feb 2008 12:03:19 -0800 Subject: [companion-integrate] RTI - Update of SFWsudo Package In-Reply-To: <47BE9442.1000309@gmail.com> References: <47BE9442.1000309@gmail.com> Message-ID: <47C31F07.10903@Sun.COM> Steven M. Christensen wrote: > This is a RTI for the update of SFWsudo from version 1.6.9p4 to version > 1.6.9p13. The webrev is at > > http://companion.sunfreeware.com/downloads/sudowebrev/ approved. From Mike.Sullivan at sun.com Mon Feb 25 12:05:14 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Mon, 25 Feb 2008 12:05:14 -0800 Subject: [companion-integrate] RTI - Update of SFWsnort Package In-Reply-To: <47C1F8D3.1050800@gmail.com> References: <47C1F8D3.1050800@gmail.com> Message-ID: <47C31F7A.1050205@Sun.COM> Steven M. Christensen wrote: > This is a RTI for the update of the SFWsnort package to version 2.8.0.2. > go for it.