[companion-integrate] RTI - Update of SFWafio Package

Mike Sullivan Mike.Sullivan at sun.com
Tue Feb 19 11:57:08 PST 2008


Steven M. Christensen wrote:
> This is a RTI for the update of the afio Companion CD package to version 
> 2.5 and a complete redo on its build structure to match the Companion 
> standard.

> 2.  The afio 2.5 source file has been added.
> 3.  A METADATA has been added.

Is freshmeat.net really the best thing to put in the
URL spot? I thought of that site more of a directory
not the true location. And since the tar file seems to be
on ibiblio or in somebody's home directory it would seem
like there must be a better place. Hmm though the README
does point out freshmeat - so maybe it's fine.

Actually it looks like it's licensed under the LGPL and
the perl Artistic license, plus at least 2 more.

> 4.  The Makefile.sfw file has been modified to fit the normal build
>      method.

You really shouldn't have to add -L/usr/lib or -R/usr/lib I'd think,
unless you're trying to force a search order (perhaps you are though).

Since some CFLAGS are no longer forced, does it properly pick the
right ones? notably fdformat/gzip? Ah I see fdformat in the patch
but please make sure it still builds the same way (I'm assuming
the old way worked :)

BTW you can probably not add the .SUFFIXES anymore - I just removed
that for sfw because it was only for building the source packages,
which we (and you) don't do anymore.

> 5.  A patch to the CFLAGS in the Makefile has been added.
> 6.  An install-sfw file has been added.

Shouldn't you use the install.subr functions there instead?

	Mike



More information about the companion-integrate mailing list