From Mike.Sullivan at sun.com Mon Jan 7 10:08:07 2008 From: Mike.Sullivan at sun.com (Mike.Sullivan at sun.com) Date: Mon, 7 Jan 2008 10:08:07 -0800 (PST) Subject: [companion-integrate] RTI - Update of SFWglob package Message-ID: <200801071808.m07I87Jj486290@yavin.Eng.Sun.COM> >From companion-integrate-bounces at opensolaris.org Mon Dec 10 03:17:47 2007 >This is a RTI for the update of the >SFWglob (global) package to version 5.6.2. approved (since it doesn't look like it was integrated yet). Mike From Mike.Sullivan at sun.com Tue Jan 8 11:53:13 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 08 Jan 2008 11:53:13 -0800 Subject: [companion-integrate] RTI - Update of fltk package In-Reply-To: <47679F3C.4070904@smc.vnet.net> References: <47679F3C.4070904@smc.vnet.net> Message-ID: <4783D4A9.2020602@Sun.COM> Steve Christensen wrote: > This is a RTI for the update of the > SFWfltk (fltk) package to version 1.1.7. approved without looking much. don't make me regret it :) Mike From steve at smc.vnet.net Mon Jan 14 02:18:20 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Mon, 14 Jan 2008 05:18:20 -0500 Subject: [companion-integrate] RTI - Update of SFWfile Packages Message-ID: <478B36EC.9040501@smc.vnet.net> This is a RTI for the update of the SFWfile package to version 4.23. The webrev is at http://companion.sunfreeware.com/downloads/filewebrev/ The code has been reviewed by Paul Cunningham and approved. The changes are very simple. 1. Update of version numbers where needed. 2. Update of copyright dates. A nightly build works with no errors on NV 76. Steve Christensen From Mike.Sullivan at sun.com Mon Jan 14 11:59:22 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Mon, 14 Jan 2008 11:59:22 -0800 Subject: [companion-integrate] RTI - Update of SFWfile Packages In-Reply-To: <478B36EC.9040501@smc.vnet.net> References: <478B36EC.9040501@smc.vnet.net> Message-ID: <478BBF1A.2070406@Sun.COM> Steve Christensen wrote: > This is a RTI for the update of the > SFWfile package to version 4.23. > approved From steve at smc.vnet.net Mon Jan 14 23:48:07 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Tue, 15 Jan 2008 02:48:07 -0500 Subject: [companion-integrate] RTI - Update of SFWpftpd Package Message-ID: <478C6537.2050809@smc.vnet.net> This is a RTI for the update of the SFWpftpd (proftpd) package to version 1.3.1. The webrev is at http://companion.sunfreeware.com/downloads/proftpdwebrev/ The code has been reviewed by Norm Jacobs and approved. Details: 1. Version numbers updated where needed. 2. Copyright year updated in various files. 3. SCCS id lines removed. 4. Source file updated. 5. Patch that is no longer needed removed. A nightly build is OK on NV 76. The package installs properly with no errors and appears to produce working programs. Steve Christensen From Mike.Sullivan at sun.com Tue Jan 15 13:02:58 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 15 Jan 2008 13:02:58 -0800 Subject: [companion-integrate] RTI - Update of SFWpftpd Package In-Reply-To: <478C6537.2050809@smc.vnet.net> References: <478C6537.2050809@smc.vnet.net> Message-ID: <478D1F82.4000205@Sun.COM> Steve Christensen wrote: > This is a RTI for the update of the SFWpftpd (proftpd) package to > version 1.3.1. > approved From steve at smc.vnet.net Thu Jan 17 22:17:22 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Fri, 18 Jan 2008 01:17:22 -0500 Subject: [companion-integrate] RTI - Update of tclx and expect packages Message-ID: <47904472.9060003@smc.vnet.net> This is a RTI for the updates of the SFWtclx (tclx) and SFWexpect (expect) packages. (Note that expect will shortly be part of Nevada and will then be removed from the Companion. For now, the update was done so that a full nightly build could be finished.) Tcl and Tk source directories are added as both tclx and expect need the source to build. The webrev is at http://companion.sunfreeware.com/downloads/tclxexpectwebrev/ The code has been reviewed by Paul Cunningham and approved. His only minor issue was the Copyright dates - which was resolved. Details - 1. Source code files updated. 2. METADATA files added. 3. The Tcl and Tk directories are there only to supply source code availability. 4. Version numbers and Copyrights updated where needed. 5. ./configure options modified to point to the correct tcl and tk source directories. 6. prototype_com and pkginfo.tmpl modified with new files and directories. 7. Various patches removed that are no longer needed and new patch created. 8. Targetdirs and Makefiles updated to deal with tcl and tk source directories and tclx directories. This builds with no problems or errors on NV 76. Steve Christensen From steve at smc.vnet.net Mon Jan 21 02:52:48 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Mon, 21 Jan 2008 05:52:48 -0500 Subject: [companion-integrate] RTI - Update of SFWmutt and SFWslang Packages Message-ID: <47947980.8080906@smc.vnet.net> This is a RTI for updates of the SFWmutt and SFWslang packages. These are done together because mutt will not build with the previous slang package version. The webrev is at http://companion.sunfreeware.com/downloads/muttslangwebrev/ This has been reviewed and approved by Paul Cunningham with no further comments. Details: 1. Source code files updated and .gz compression replaced with .bz2. 2. Copyrights updated to 2008 and sccs ids removed where needed. 3. Mutt METADATA file added and slang METADATA file updated. 4. patch.Muttrc file updated for most recent Muttrc file. 5. Some slang library files that are no longer created removed from prototype_com file. 6. Library file names updated. 7. Version numbers updated where needed. 8. Web sites in pkginfo.tmpl and METADATA files updated if needed. The changed files work in a nightly build with no errors on NV 76. Packages install properly and mutt program starts up normally. Steve Christensen From Mike.Sullivan at sun.com Tue Jan 22 11:57:09 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 22 Jan 2008 11:57:09 -0800 Subject: [companion-integrate] RTI - Update of tclx and expect packages In-Reply-To: <47904472.9060003@smc.vnet.net> References: <47904472.9060003@smc.vnet.net> Message-ID: <47964A95.1030106@Sun.COM> Steve Christensen wrote: > This is a RTI for the updates of the SFWtclx (tclx) and > SFWexpect (expect) packages. (Note that expect will shortly be part of > Nevada and will then be removed from the Companion. For now, the update > was done so that a full nightly build could be finished.) > 2. METADATA files added. Since expect will soon be deleted from the ccd, I'm not sure there is a point to adding a METADATA file for it. If you do, then the license is wrong, it's not gpl it's public domain + GPL I believe. You may have been mislead because since it contains a test program which is under the GPL, when it was bundled we indeed had to treat it as GPL'd and so the SUNWexpect package has bits about the GPL in the copyright file. but it's probably easiest to just not create a METADATA file in the first place. Unless you're intending to push this back into an s10 update ccd, but you probably can't do that since the tcl/tk you need won't be there. Kinda interesting you still have a patch to make it use GNU tail, but the bundled expect doesn't need it? that might be a good question to ask the integrator of expect into sfw. I don't understand why SFWctags was moved in pkgdefs/Makefile. > 3. The Tcl and Tk directories are there only to supply source code > availability. I might actually note that in comments in the tcl/tk Makefile.sfw's. Along with noting the need to track upgrades in Solaris. Mike From Mike.Sullivan at sun.com Tue Jan 22 12:07:32 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 22 Jan 2008 12:07:32 -0800 Subject: [companion-integrate] RTI - Update of SFWmutt and SFWslang Packages In-Reply-To: <47947980.8080906@smc.vnet.net> References: <47947980.8080906@smc.vnet.net> Message-ID: <47964D04.803@Sun.COM> Steve Christensen wrote: > This is a RTI for updates of the SFWmutt and SFWslang packages. > 1. Source code files updated and .gz compression replaced with .bz2. I will just note - while I like saving space and xfer time, I hope you're not just recompressing the tar files. I really like the idea that we just redistribute what is downloadable from the real source, and don't like even making it look like we might have done something to it privately. While I should be able to convince myself that recompressing is fine if they do provide a .bz2'd archive, if they _don't_ then it could indeed look like we changed it. Ah well if nobody else cares I guess it can just be me. And certainly just preferring the better-compressed archive if they have one is fine. SFWmutt/prototype_com seems to only have a copyright change and sccs-id removal and nothing else? I'd think there should be a real change there before we do those. Mike From steve at smc.vnet.net Tue Jan 22 12:53:51 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Tue, 22 Jan 2008 15:53:51 -0500 Subject: [companion-integrate] RTI - Update of SFWmutt and SFWslang Packages In-Reply-To: <47964D04.803@Sun.COM> References: <47947980.8080906@smc.vnet.net> <47964D04.803@Sun.COM> Message-ID: <479657DF.5080806@smc.vnet.net> Mike - Unless there are any comments negatively, from now on I will only use .bz2 sources if they are offered by the developers. I have been replacing .gz with .bz2 for some time now, but will follow your suggestion. As for just removing sccs ids in a file, that was done for completeness, but I can stop that as well if that is the only thing that changes in a file. What changes do you want me to make with this RTI before approval? Steve C. Mike Sullivan wrote: > Steve Christensen wrote: >> This is a RTI for updates of the SFWmutt and SFWslang packages. > >> 1. Source code files updated and .gz compression replaced with .bz2. > > I will just note - while I like saving space and xfer time, I hope > you're not just recompressing the tar files. I really like the idea > that we just redistribute what is downloadable from the real source, > and don't like even making it look like we might have done something > to it privately. While I should be able to convince myself that > recompressing is fine if they do provide a .bz2'd archive, if they > _don't_ then it could indeed look like we changed it. Ah well if > nobody else cares I guess it can just be me. And certainly just > preferring the better-compressed archive if they have one is fine. > > > SFWmutt/prototype_com seems to only have a copyright change and > sccs-id removal and nothing else? I'd think there should be a > real change there before we do those. > > Mike > From Mike.Sullivan at sun.com Tue Jan 22 12:59:11 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 22 Jan 2008 12:59:11 -0800 Subject: [companion-integrate] RTI - Update of SFWmutt and SFWslang Packages In-Reply-To: <479657DF.5080806@smc.vnet.net> References: <47947980.8080906@smc.vnet.net> <47964D04.803@Sun.COM> <479657DF.5080806@smc.vnet.net> Message-ID: <4796591F.3080602@Sun.COM> Steve Christensen wrote: > Mike - > > Unless there are any comments negatively, from now on I will only use > .bz2 sources if they are offered by the developers. I have been > replacing .gz with .bz2 for some time now, but will follow your > suggestion. I know, it's just been bothering me for some time so I thought I'd finally say something so others can tell me to stop worrying if they want :) > As for just removing sccs ids in a file, that was done for > completeness, but I can stop that as well if that is the only thing > that changes in a file. yes please. You're definitely not supposed to just update a file to change the copyright anyway (it's supposed to be done for 'significant' changes), and since I thought you were just removing sccs-id's when you're touching files for other reasons I think you should act the same way. >What changes do you want me to make with this > RTI before approval? don't do the copyright/sccs-id updates unless there's an actual change needed in prototype_com. That's it really. Mike From steve at smc.vnet.net Tue Jan 22 14:29:07 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Tue, 22 Jan 2008 17:29:07 -0500 Subject: [companion-integrate] RTI - Update of SFWmutt and SFWslang Packages In-Reply-To: <4796591F.3080602@Sun.COM> References: <47947980.8080906@smc.vnet.net> <47964D04.803@Sun.COM> <479657DF.5080806@smc.vnet.net> <4796591F.3080602@Sun.COM> Message-ID: <47966E33.1000006@smc.vnet.net> Mike - I have updated the webrev http://companion.sunfreeware.com/downloads/muttslangwebrev/ with the removal of the prototype_com change as you suggest. If you are OK with this, I will do the commit. Steve C. Mike Sullivan wrote: > Steve Christensen wrote: >> Mike - >> >> Unless there are any comments negatively, from now on I will only use >> .bz2 sources if they are offered by the developers. I have been >> replacing .gz with .bz2 for some time now, but will follow your >> suggestion. > > I know, it's just been bothering me for some time so I thought I'd > finally say something so others can tell me to stop worrying if > they want :) > > > As for just removing sccs ids in a file, that was done for >> completeness, but I can stop that as well if that is the only thing >> that changes in a file. > > yes please. You're definitely not supposed to just update a file > to change the copyright anyway (it's supposed to be done for > 'significant' changes), and since I thought you were just removing > sccs-id's when you're touching files for other reasons I think > you should act the same way. > > > >What changes do you want me to make with this >> RTI before approval? > > don't do the copyright/sccs-id updates unless there's an actual > change needed in prototype_com. That's it really. > > Mike > From Mike.Sullivan at sun.com Tue Jan 22 14:33:27 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Tue, 22 Jan 2008 14:33:27 -0800 Subject: [companion-integrate] RTI - Update of SFWmutt and SFWslang Packages In-Reply-To: <47966E33.1000006@smc.vnet.net> References: <47947980.8080906@smc.vnet.net> <47964D04.803@Sun.COM> <479657DF.5080806@smc.vnet.net> <4796591F.3080602@Sun.COM> <47966E33.1000006@smc.vnet.net> Message-ID: <47966F37.8090401@Sun.COM> Steve Christensen wrote: > Mike - > > I have updated the webrev > > http://companion.sunfreeware.com/downloads/muttslangwebrev/ > > with the removal of the prototype_com change as you suggest. > > If you are OK with this, I will do the commit. yep, approved. Mike From steve at smc.vnet.net Wed Jan 23 02:19:14 2008 From: steve at smc.vnet.net (Steve Christensen) Date: Wed, 23 Jan 2008 05:19:14 -0500 Subject: [companion-integrate] RTI - Update of tclx and expect packages In-Reply-To: <47964A95.1030106@Sun.COM> References: <47904472.9060003@smc.vnet.net> <47964A95.1030106@Sun.COM> Message-ID: <479714A2.9000705@smc.vnet.net> Mike - The webrev http://companion.sunfreeware.com/downloads/tclxexpectwebrev/ is updated. I have removed the expect METADATA file. I fixed pkgdefs/Makefile which did not need the ctags change. I added comments in the tcl and tk Makefile.sfw files as you indicated. The tail issue in the sfw integration of expect is something we will have to investigate independently of this. Any other comments? Steve C. Mike Sullivan wrote: > Steve Christensen wrote: >> This is a RTI for the updates of the SFWtclx (tclx) and >> SFWexpect (expect) packages. (Note that expect will shortly be part >> of Nevada and will then be removed from the Companion. For now, the >> update was done so that a full nightly build could be finished.) > >> 2. METADATA files added. > > Since expect will soon be deleted from the ccd, I'm not sure > there is a point to adding a METADATA file for it. If you do, > then the license is wrong, it's not gpl it's public domain + GPL > I believe. You may have been mislead because since it contains > a test program which is under the GPL, when it was bundled > we indeed had to treat it as GPL'd and so the SUNWexpect package > has bits about the GPL in the copyright file. > > but it's probably easiest to just not create a METADATA file > in the first place. Unless you're intending to push this > back into an s10 update ccd, but you probably can't do that > since the tcl/tk you need won't be there. > > Kinda interesting you still have a patch to make it use > GNU tail, but the bundled expect doesn't need it? that > might be a good question to ask the integrator of > expect into sfw. > > I don't understand why SFWctags was moved in pkgdefs/Makefile. > >> 3. The Tcl and Tk directories are there only to supply source code >> availability. > > I might actually note that in comments in the tcl/tk Makefile.sfw's. > Along with noting the need to track upgrades in Solaris. > > Mike > From Mike.Sullivan at sun.com Thu Jan 24 14:05:35 2008 From: Mike.Sullivan at sun.com (Mike Sullivan) Date: Thu, 24 Jan 2008 14:05:35 -0800 Subject: [companion-integrate] RTI - Update of tclx and expect packages In-Reply-To: <479714A2.9000705@smc.vnet.net> References: <47904472.9060003@smc.vnet.net> <47964A95.1030106@Sun.COM> <479714A2.9000705@smc.vnet.net> Message-ID: <47990BAF.1060601@Sun.COM> Steve Christensen wrote: > Mike - > > The webrev > > http://companion.sunfreeware.com/downloads/tclxexpectwebrev/ > > is updated. > > I have removed the expect METADATA file. I fixed pkgdefs/Makefile which > did not need the ctags change. I added comments in the tcl and tk > Makefile.sfw files as you indicated. tcllx seems to have an extra l in tk/Makefile.sfw. > > The tail issue in the sfw integration of expect is something > we will have to investigate independently of this. ok. > > Any other comments? well I'm now re-wondering if we need to really ship the tcl/tk source in solaris, since it came up in the OSS arc case. See: http://mail.opensolaris.org/pipermail/opensolaris-arc/2008-January/005899.html but that's probably just something to worry about. this is otherwise approved. Mike